All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gary Thomas <gary@mlbassoc.com>
To: Javier Martinez Canillas <martinez.javier@gmail.com>
Cc: Enrico <ebutera@users.berlios.de>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Deepthy Ravi <deepthy.ravi@ti.com>,
	Adam Pledger <a.pledger@thermoteknix.com>,
	linux-media@vger.kernel.org, Sakari Ailus <sakari.ailus@iki.fi>
Subject: Re: omap3-isp status
Date: Fri, 07 Oct 2011 05:39:19 -0600	[thread overview]
Message-ID: <4E8EE4E7.7040300@mlbassoc.com> (raw)
In-Reply-To: <CAAwP0s31cSh+T-k=9f+_M845aQG3M5N82NPYALdVkDn5FogmWg@mail.gmail.com>

On 2011-10-07 05:02, Javier Martinez Canillas wrote:
> On Fri, Oct 7, 2011 at 12:36 PM, Enrico<ebutera@users.berlios.de>  wrote:
>> On Fri, Oct 7, 2011 at 12:22 PM, Gary Thomas<gary@mlbassoc.com>  wrote:
>>> Do we know for sure that these problems are happening in the ISP itself
>>> or could they possibly be in the TVP5150?  Does anyone have experience
>>> with a different analogue encoder?
>>
>> Never tried another encoder, but at this point it's something to look
>> at. I don't think some TI people will say "yes the encoder has
>> ghosting artifacts".
>>
>> Enrico
>>
>
> I have never tried with an different decoder either. I don't think
> this is a HW thing. As far as I know the tvp5150 is used in some
> em28xx devices that is what Mauro said, and he would notice that
> behaviour.
>
> Also, if you try getting 625 lines (for PAL) but disable the
> line-output-formatter for deinterlacing, i.e:
>
> pdata->fldmode = 0;
>
> ispccdc_config_outlineoffset(ccdc, pix.bytesperline, EVENEVEN, 0);
> ispccdc_config_outlineoffset(ccdc, pix.bytesperline, EVENODD, 0);
> ispccdc_config_outlineoffset(ccdc, pix.bytesperline, ODDEVEN, 0);
> ispccdc_config_outlineoffset(ccdc, pix.bytesperline, ODDODD, 0);
>
> Then you get a frame with the 313 odd lines and 312 even lines
> correctly. That means that the TVP5151 is generating correctly the
> interlaced video.
>
> Also the ISP is doing correctly the deinterlacing for a some frames.
> But all the approaches used so far (wait for two VD0 interrupt to
> change the CCCDC output memory direction), looks more like a hack than
> a clean solution to me, but maybe is the only way to do it with the
> ISP.

Looking at your sequence of pictures, you can see that image #10 and #11
are pretty good, but #12..14 are all bad, then #15 & 16 are OK again.
In the bad ones, it looks like every other line has been shifted left by
some number of pixels.  It's hard to tell, but I think the shift is constant
when it happens.

>
> My guess is that the problem is the ISP driver that before this
> configuration (TVP5150/1 + ISP) had never been tested with an video
> decoder that generates interlaced data.

Of course, there's the comment in the manual that says it's not supported :-)
According to 12.4.4.1, BT656 (ITU) data can only use progressive scan sensors.

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

  reply	other threads:[~2011-10-07 11:39 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-05 16:28 omap3-isp status Enrico
2011-10-05 17:43 ` Javier Martinez Canillas
2011-10-06  7:51   ` Javier Martinez Canillas
2011-10-06 14:00     ` Gary Thomas
     [not found]       ` <CAAwP0s0ddOYAnC7rknLVzcN10iKAwnuOawznpKy9z6B2yWRdCg@mail.gmail.com>
2011-10-06 14:50         ` Javier Martinez Canillas
2011-10-06 15:47           ` Gary Thomas
2011-10-06 16:11             ` Javier Martinez Canillas
2011-10-07  9:34               ` Gary Thomas
2011-10-07 10:08                 ` Javier Martinez Canillas
2011-10-07 10:22                   ` Gary Thomas
2011-10-07 10:36                     ` Enrico
2011-10-07 11:02                       ` Javier Martinez Canillas
2011-10-07 11:39                         ` Gary Thomas [this message]
2011-10-07 11:50                           ` Javier Martinez Canillas
2011-10-06 15:25     ` Enrico
2011-10-06 16:05       ` Javier Martinez Canillas
2011-10-07  8:54         ` Enrico
2011-10-07  9:31           ` Javier Martinez Canillas
2011-10-08 15:51             ` Laurent Pinchart
2011-10-08 16:11               ` Javier Martinez Canillas
2011-10-09 22:35                 ` Enrico
2011-10-09 23:00                   ` Javier Martinez Canillas
2011-10-10  8:54                     ` Enrico
2011-10-10  9:02                       ` Javier Martinez Canillas
2011-10-10 10:06                         ` Enrico
2011-10-10 10:07                           ` Enrico
2011-10-10 10:33                             ` Javier Martinez Canillas
2011-10-10 12:46                               ` Enrico
2011-10-10 14:17                                 ` Enrico
2011-10-10 16:34                                   ` Enrico
2011-10-10 16:53                                     ` Javier Martinez Canillas
2011-10-10 17:09                                       ` Enrico
2011-10-10 18:18                                         ` Javier Martinez Canillas
2011-10-11 10:29                                           ` Enrico
2011-10-11 10:50                                             ` Javier Martinez Canillas
2011-10-10 12:54                               ` Enrico

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E8EE4E7.7040300@mlbassoc.com \
    --to=gary@mlbassoc.com \
    --cc=a.pledger@thermoteknix.com \
    --cc=deepthy.ravi@ti.com \
    --cc=ebutera@users.berlios.de \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=martinez.javier@gmail.com \
    --cc=sakari.ailus@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.