Re: [RFC PATCH] HDA: Generic input jack handling

[David Henningsson <david.henningsson@canonical.com>]

On 10/07/2011 02:08 PM, Takashi Iwai wrote:
> At Fri, 07 Oct 2011 13:49:46 +0200,
> David Henningsson wrote:
>>
>> So, this is what I had in mind for 3.2. Assuming positive feedback from
>> Takashi I'll go ahead and make a real patch out of this, and to clean up
>> the Realtek implementation, as well as probably add this method for more
>> codecs.
>>
>> Thoughts:
>>
>> 1) The unsol event tags vary wildly between different vendors. How about
>> standardising that as well?
>
> Generalization is good.  But tags aren't always constant.  It'd be
> better to assign each tag dynamically like in patch_sigmatel.c.
> The reason is that you'd need to know the pin NID from the unsol
> event, so the tag has to be unique even for the same purpose.  E.g. if
> a machine has two headphones, both are the same type but they should
> issue unsol events with different tags.

One would think that this is an area where it shouldn't differ between 
vendors (after all, they need to do the same things, so this is just 
different implementations), but we can clean that up later, and when 
that is done we could consider standardising on having the nid as the 
unsol tag value.
Anyway, as the patch below stands, sigmatel would call the function with 
unsol_tags->unsol_tag = 0, and then enable the jack itself.

Did you think the patch looked good otherwise?

>> 2) If alc_init_jacks would call the new method, that might regress
>> model-based (non auto) parsers. Is that a big deal these days?
>
> I don't think so.  And most of all model-based entries will vanish in
> 3.3.  In 3.2, already a half of realtek quirks are gone.

Ok.

-- 
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic