From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: AT commands not being parsed correctly from Samsung Wave HFP
Date: Fri, 07 Oct 2011 08:33:22 -0500 [thread overview]
Message-ID: <4E8EFFA2.6010009@gmail.com> (raw)
In-Reply-To: <4E8EDB0D.9020304@bmw-carit.de>
[-- Attachment #1: Type: text/plain, Size: 881 bytes --]
Hi Mikel,
>
> Right, the permissive one works perfectly. The phone has passed all our
> tests.
>
> Now the next question is whether it would make sense to switch the HFP
> plugin to this parser, or this would rather be done selectively.
>
It should be fine to switch to the permissive syntax parser permanently.
The reason we used gsmv1 are largely historical (permissive did not
exist at the time) and we also wanted to gauge just how broken some HFP
implementations were.
> Which would be the drawbacks of using the permissive parser for all phones?
>
Permissive has rather limited support for command echo (e.g. ATE1), but
that should not cause any problems with HFP since the spec mandates echo
to be disabled by default. However, if manufacturers can't get <CR><LF>
terminators right, maybe they also get this part wrong ;)
Regards,
-Denis
prev parent reply other threads:[~2011-10-07 13:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 17:45 AT commands not being parsed correctly from Samsung Wave HFP Mikel Astiz
2011-10-06 18:02 ` Denis Kenzior
2011-10-07 10:57 ` Mikel Astiz
2011-10-07 13:33 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8EFFA2.6010009@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.