From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RCEv6-00015K-A2 for qemu-devel@nongnu.org; Fri, 07 Oct 2011 14:13:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RCEv5-0004zu-6B for qemu-devel@nongnu.org; Fri, 07 Oct 2011 14:13:16 -0400 Received: from mail-wy0-f173.google.com ([74.125.82.173]:62760) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RCEv4-0004zn-V5 for qemu-devel@nongnu.org; Fri, 07 Oct 2011 14:13:15 -0400 Received: by wyh22 with SMTP id 22so4718532wyh.4 for ; Fri, 07 Oct 2011 11:13:13 -0700 (PDT) Sender: Richard Henderson Message-ID: <4E8F4133.9000404@twiddle.net> Date: Fri, 07 Oct 2011 11:13:07 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1318010451-24790-1-git-send-email-Stefan.Weil@Kath-Kirche-Ladenburg.de> In-Reply-To: <1318010451-24790-1-git-send-email-Stefan.Weil@Kath-Kirche-Ladenburg.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] tcg: Introduce TCGReg for all TCG hosts (fixes build for s390 hosts) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: blauwirbel@gmail.com, borntraeger@de.ibm.com, qemu-devel@nongnu.org, agraf@suse.de On 10/07/2011 11:00 AM, Stefan Weil wrote: > +#define TCGReg int /* TODO: Remove this line when tcg-target.c uses TCGReg. */ Nack. This is too ugly to live. How hard can it be to simply change the prototype in each of the backend files instead? Yes, full conversion to TCGReg is desirable, but this is not C++ -- integers and enums are interchangable without casts. r~