From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:40858)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RCF9K-00050K-3I
	for qemu-devel@nongnu.org; Fri, 07 Oct 2011 14:27:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RCF9I-0008FQ-8G
	for qemu-devel@nongnu.org; Fri, 07 Oct 2011 14:27:58 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:46353)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RCF9I-0007zN-1G
	for qemu-devel@nongnu.org; Fri, 07 Oct 2011 14:27:56 -0400
Message-ID: <4E8F446D.1090102@weilnetz.de>
Date: Fri, 07 Oct 2011 20:26:53 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1318010451-24790-1-git-send-email-Stefan.Weil@Kath-Kirche-Ladenburg.de>
	<4E8F4133.9000404@twiddle.net>
In-Reply-To: <4E8F4133.9000404@twiddle.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] tcg: Introduce TCGReg for all TCG hosts
 (fixes build for s390 hosts)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: blauwirbel@gmail.com, borntraeger@de.ibm.com, qemu-devel@nongnu.org, agraf@suse.de

Am 07.10.2011 20:13, schrieb Richard Henderson:
> On 10/07/2011 11:00 AM, Stefan Weil wrote:
>> +#define TCGReg int /* TODO: Remove this line when tcg-target.c uses 
>> TCGReg. */
>
> Nack. This is too ugly to live.
>
> How hard can it be to simply change the prototype in each
> of the backend files instead? Yes, full conversion to
> TCGReg is desirable, but this is not C++ -- integers and
> enums are interchangable without casts.
>
> r~

The goal of my patch is to get code which compiles again
on all hosts with minimum risk and which is a base for further
improvements.

I cannot run build tests for all possible hosts, and even
changing 4 prototypes for each host is a risk when it is not
tested. Yes, you can review the changes, some developers can
try builds, but that takes a lot of time.

As soon as my patch is applied, it is possible to add
more TCGReg usage to tcg.c, s390/tcg-target.c and all
other TCG targets in independent patches.

I'm just preparing patches for tcg.c and i386/tcg-target.*.

But let me repeat: these new patches need a good review
which will take some time. The bug fix should be applied soon.
Maybe you can change your mind and send an ack.

- Stefan