From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?THVrw6HFoSBEb2t0b3I=?= Subject: Re: [kvm-autotest] cgroup-kvm: Four new BlkioThrottle tests Date: Fri, 07 Oct 2011 20:43:24 +0200 Message-ID: <4E8F484C.1050706@redhat.com> References: <1318011850-17580-1-git-send-email-ldoktor@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: autotest@test.kernel.org, kvm@vger.kernel.org, kvm-autotest@redhat.com, akong@redhat.com, lmr@redhat.com, jzupka@redhat.com To: Lukas Doktor Return-path: Received: from mx1.redhat.com ([209.132.183.28]:11340 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751371Ab1JGSna (ORCPT ); Fri, 7 Oct 2011 14:43:30 -0400 In-Reply-To: <1318011850-17580-1-git-send-email-ldoktor@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Dne 7.10.2011 20:24, Lukas Doktor napsal(a): > This is a patchset with four new tests to KVM specific cgroup testing= =2E Also I made some modifications into (general) cgroup_common library= which makes cgroup testing better readable and more safe to execute. P= lease find the details in each patch. > > Also please beware of qemu-kvm bugs which occurred for me (qemu-kvm 0= =2E15.0 F17) which led to qemu SEGFAULTS or even to dysfunction (qemu-k= vm 0.14 F15). I'll fill in Bugzilla on Monday. > > This was also sent as a github pull request, so if you feel like comm= enting on the pull request, be my guest: > https://github.com/autotest/autotest/pull/33 > > Best regards, > Luk=C3=A1=C5=A1 Already one minor change, please follow the patches on github... diff --git a/client/tests/kvm/tests/cgroup.py=20 b/client/tests/kvm/tests/cgroup.py index 7f00a6b..7407e29 100644 --- a/client/tests/kvm/tests/cgroup.py +++ b/client/tests/kvm/tests/cgroup.py @@ -409,7 +409,13 @@ def run_cgroup(test, params, env): raise error.TestError("Corrupt class, aren't you=20 trying to run "parent _TestBlkioThrottle()=20 function?") - (self.files, self.devices) =3D add_scsi_drive(self.vm) + if get_device_driver() =3D=3D "ide": + logging.warn("The main disk for this VM is ide wich=20 doesn't " + "support hot-plug. Using virtio_blk inste= ad") + (self.files, self.devices) =3D add_scsi_drive(self.vm, + =20 driver=3D"virtio") + else: + (self.files, self.devices) =3D add_scsi_drive(self.vm) try: dev =3D utils.system_output("ls -l %s" %=20 self.files).split()[4:6] dev[0] =3D dev[0][:-1] # Remove tailing ','