All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel De Graaf <dgdegra@tycho.nsa.gov>
To: Ian Campbell <ian.campbell@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: [PATCH] libxlu: correctly parse disk "backendtype" field
Date: Fri, 07 Oct 2011 16:50:20 -0400	[thread overview]
Message-ID: <4E8F660C.4010405@tycho.nsa.gov> (raw)
In-Reply-To: <50cd0fd187b39a263680.1317313232@localhost.localdomain>

The expression for backendtype was missing a comma.

--- a/tools/libxl/libxlu_disk_l.l
+++ b/tools/libxl/libxlu_disk_l.l
@@ -139,7 +139,7 @@ devtype=disk,?	{ DPC->disk->is_cdrom = 0; }
 devtype=[^,]*,?	{ xlu__disk_err(DPC,yytext,"unknown value for type"); }
 
 access=[^,]*,?	{ STRIP(','); setaccess(DPC, FROMEQUALS); }
-backendtype=[^,]*? { STRIP(','); setbackendtype(DPC,FROMEQUALS); }
+backendtype=[^,]*,? { STRIP(','); setbackendtype(DPC,FROMEQUALS); }
 
 vdev=[^,]*,?	{ STRIP(','); SAVESTRING("vdev", vdev, FROMEQUALS); }
 script=[^,]*,?	{ STRIP(','); SAVESTRING("script", script, FROMEQUALS); }

  parent reply	other threads:[~2011-10-07 20:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-29 16:20 [PATCH 0 of 6] libxl: support json for pretty printing objects Ian Campbell
2011-09-29 16:20 ` [PATCH 1 of 6] libxl: IDL: autogenerate functions to produce JSON from libxl data structures Ian Campbell
2011-10-06 14:55   ` Ian Jackson
2011-10-07  8:34     ` Ian Campbell
2011-09-29 16:20 ` [PATCH 2 of 6] xl: allow check-xl-disk-parse to run against installed xl as well as build dir Ian Campbell
2011-10-06 14:57   ` Ian Jackson
2011-10-06 15:27     ` Ian Campbell
2011-09-29 16:20 ` [PATCH 3 of 6] xl: use libxl_device_disk_to_json to pretty print disk configuration Ian Campbell
2011-10-06 15:16   ` Ian Jackson
2011-09-29 16:20 ` [PATCH 4 of 6] libxl: undo 23728:548b2826293e whitespace cleanup to autogenerated file Ian Campbell
2011-10-06 15:15   ` Ian Jackson
2011-09-29 16:20 ` [PATCH 5 of 6] libxlu: correctly parse disk "backendtype" field Ian Campbell
2011-10-06 15:20   ` Ian Jackson
2011-10-07 20:50   ` Daniel De Graaf [this message]
2011-10-07 21:41     ` [PATCH] " Ian Campbell
2011-10-07 22:28       ` Daniel De Graaf
2011-10-10 10:25         ` Ian Jackson
2011-09-29 16:20 ` [PATCH 6 of 6] libxl: probe disk backend type in libxl_device_disk_add Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E8F660C.4010405@tycho.nsa.gov \
    --to=dgdegra@tycho.nsa.gov \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.