All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Jin <joe.jin@oracle.com>
To: Matt Carlson <mcarlson@broadcom.com>
Cc: Xiao Jiang <jgq516@gmail.com>, Michael Chan <mchan@broadcom.com>,
	Guru Anbalagane <guru.anbalagane@oracle.com>,
	Gurudas Pai <gurudas.pai@oracle.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Greg Marsden <greg.marsden@oracle.com>
Subject: Re: [PATCH] tg3: Dont dump registers if interface not ready.
Date: Sat, 08 Oct 2011 11:21:03 +0800	[thread overview]
Message-ID: <4E8FC19F.9060305@oracle.com> (raw)
In-Reply-To: <20111005021423.GA2787@mcarlson.broadcom.com>

>>>  
>>> +	/* If interface not ready then dont dump error */
>>> +	if (!netif_carrier_ok(tp->dev))
>>> +		dump = false;
> 
> Would you still experience the problem if you did the following instead
> of the above link check?
> 
> 		if (tg3_flag(tp, INIT_COMPLETE))
> 			dump = false;

I'll try it then update you.

Thanks,
Joe


  reply	other threads:[~2011-10-08  3:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-29  2:10 [PATCH] tg3: Dont dump registers if interface not ready Joe Jin
2011-09-29  6:50 ` Xiao Jiang
2011-10-05  2:14   ` Matt Carlson
2011-10-08  3:21     ` Joe Jin [this message]
2011-10-17  9:52     ` Joe Jin
2012-03-22 13:17       ` Luis Henriques

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E8FC19F.9060305@oracle.com \
    --to=joe.jin@oracle.com \
    --cc=greg.marsden@oracle.com \
    --cc=guru.anbalagane@oracle.com \
    --cc=gurudas.pai@oracle.com \
    --cc=jgq516@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcarlson@broadcom.com \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.