[PATCH] qemu-kvm: Deprecate drive parameter boot=on|off

[Jan Kiszka <jan.kiszka@web.de>]

On 2011-10-07 13:16, Jan Kiszka wrote:
> Except for booting from SCSI via the LSI controller, SeaBIOS has native
> support for mass storage interfaces now. And SCSI can be worked around
> via [1] - or someone finally adds the necessary bits to SeaBIOS if there
> is a real need.
> 
> As there might be still scripts around that append "boot=on", continue
> to parse it, but ignore it and issue a deprecation warning instead.
> 
> [1] http://thread.gmane.org/gmane.comp.emulators.qemu/78467
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> 
> Changes in v2:
>  - restore accidentally removed VAPIC option ROM installation
>  - continue to parse boot=on|off

As a different version was merged now, here is the required delta patch:

-----8<-----

From: Jan Kiszka <jan.kiszka@siemens.com>

We do not want to maintain this option forever. It will be removed after
a grace period of a few releases. So warn the user that this option has
no effect and will become invalid soon.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 blockdev.c    |    6 ++++++
 qemu-config.c |    2 +-
 2 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/blockdev.c b/blockdev.c
index 0827bf7..9678915 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -353,6 +353,12 @@ DriveInfo *drive_init(QemuOpts *opts, int default_to_scsi)
         }
     }
 
+    if (qemu_opt_get(opts, "boot") != NULL) {
+        fprintf(stderr, "qemu-kvm: boot=on|off is deprecated and will be "
+                "ignored. Future versions will reject this parameter. Please "
+                "update your scripts.\n");
+    }
+
     on_write_error = BLOCK_ERR_STOP_ENOSPC;
     if ((buf = qemu_opt_get(opts, "werror")) != NULL) {
         if (type != IF_IDE && type != IF_SCSI && type != IF_VIRTIO && type != IF_NONE) {
diff --git a/qemu-config.c b/qemu-config.c
index acab438..72e86b9 100644
--- a/qemu-config.c
+++ b/qemu-config.c
@@ -88,7 +88,7 @@ static QemuOptsList qemu_drive_opts = {
         },{
             .name = "boot",
             .type = QEMU_OPT_BOOL,
-            .help = "make this a boot drive",
+            .help = "(deprecated, ignored)",
         },
         { /* end of list */ }
     },