From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Subject: Re: [PATCH 1/3] traverse_trees(): allow pruning with pathspec
Date: Sun, 09 Oct 2011 17:39:29 +0200 [thread overview]
Message-ID: <4E91C031.9030205@alum.mit.edu> (raw)
In-Reply-To: <1314653603-7533-2-git-send-email-gitster@pobox.com>
On 08/29/2011 11:33 PM, Junio C Hamano wrote:
> diff --git a/tree-walk.c b/tree-walk.c
> index 33f749e..808bb55 100644
> --- a/tree-walk.c
> +++ b/tree-walk.c
> [...]
> @@ -376,16 +396,22 @@ int traverse_trees(int n, struct tree_desc *t, struct traverse_info *info)
> mask |= 1ul << i;
> if (S_ISDIR(entry[i].mode))
> dirmask |= 1ul << i;
> + e = &entry[i];
> }
> if (!mask)
> break;
> - ret = info->fn(n, mask, dirmask, entry, info);
> - if (ret < 0) {
> - error = ret;
> - if (!info->show_all_errors)
> - break;
> + interesting = prune_traversal(e, info, &base, interesting);
According to gcc 4.2.4 (though, strangely, not gcc 4.4.3):
tree-walk.c: In function ‘traverse_trees’:
tree-walk.c:347: warning: ‘e’ may be used uninitialized in this function
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
next prev parent reply other threads:[~2011-10-09 15:39 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 7:25 What's the difference between `git show branch:file | diff -u - file` vs `git diff branch file`? Marat Radchenko
2011-08-23 10:03 ` Michael J Gruber
2011-08-23 10:52 ` Marat Radchenko
2011-08-23 15:20 ` Michael Witten
2011-08-23 15:34 ` Michael J Gruber
2011-08-23 16:45 ` Marat Radchenko
2011-08-23 17:15 ` Junio C Hamano
2011-08-23 18:21 ` Marat Radchenko
2011-08-23 20:07 ` Michael J Gruber
2011-08-25 16:09 ` Marat Radchenko
2011-08-25 21:10 ` Junio C Hamano
2011-08-26 9:43 ` Marat Radchenko
2011-08-29 7:41 ` Nguyen Thai Ngoc Duy
2011-08-29 14:48 ` Marat Radchenko
2011-08-29 16:09 ` Nguyen Thai Ngoc Duy
2011-08-29 17:18 ` Junio C Hamano
2011-08-29 20:42 ` Junio C Hamano
2011-08-29 20:50 ` Junio C Hamano
2011-08-29 21:09 ` Junio C Hamano
2011-08-29 21:33 ` [PATCH 0/3] Un-pessimize "diff-index $commit -- $pathspec" Junio C Hamano
2011-08-29 21:33 ` [PATCH 1/3] traverse_trees(): allow pruning with pathspec Junio C Hamano
2011-08-30 12:53 ` Nguyen Thai Ngoc Duy
2011-08-30 17:44 ` Junio C Hamano
2011-08-31 1:35 ` Nguyen Thai Ngoc Duy
2011-10-09 15:39 ` Michael Haggerty [this message]
2011-10-09 21:35 ` Nguyen Thai Ngoc Duy
2011-10-10 4:42 ` Michael Haggerty
2011-08-29 21:33 ` [PATCH 2/3] unpack-trees: " Junio C Hamano
2011-08-30 13:03 ` Nguyen Thai Ngoc Duy
2011-08-30 17:32 ` Junio C Hamano
2011-08-30 15:24 ` David Michael Barr
2011-08-29 21:33 ` [PATCH 3/3] diff-index: pass pathspec down to unpack-trees machinery Junio C Hamano
2012-01-11 6:31 ` Jonathan Nieder
2012-01-11 8:05 ` Junio C Hamano
2012-01-11 12:33 ` Nguyen Thai Ngoc Duy
2012-01-11 12:47 ` Nguyen Thai Ngoc Duy
2012-01-11 20:40 ` Junio C Hamano
2012-01-12 4:09 ` [PATCH] tree_entry_interesting: make recursive mode default Nguyễn Thái Ngọc Duy
2012-01-12 5:04 ` Junio C Hamano
2012-01-12 5:44 ` Nguyen Thai Ngoc Duy
2012-01-14 9:23 ` [PATCH v2 1/2] Document limited recursion pathspec matching with wildcards Nguyễn Thái Ngọc Duy
2012-01-14 9:23 ` [PATCH v2 2/2] tree_entry_interesting: make recursive mode default Nguyễn Thái Ngọc Duy
2012-01-15 3:12 ` Junio C Hamano
2012-01-15 10:03 ` Nguyen Thai Ngoc Duy
2012-01-16 22:15 ` Junio C Hamano
2012-01-18 8:59 ` Nguyen Thai Ngoc Duy
2012-01-15 2:38 ` [PATCH v2 1/2] Document limited recursion pathspec matching with wildcards Junio C Hamano
2012-01-15 9:48 ` Nguyen Thai Ngoc Duy
2011-08-29 21:56 ` [PATCH 0/3] Un-pessimize "diff-index $commit -- $pathspec" Linus Torvalds
2011-08-29 22:05 ` Junio C Hamano
2011-08-29 22:11 ` Linus Torvalds
2011-08-29 23:42 ` Junio C Hamano
2011-08-30 6:16 ` Marat Radchenko
2011-08-31 0:18 ` Junio C Hamano
2011-08-30 10:04 ` Michael J Gruber
2011-08-30 17:03 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E91C031.9030205@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.