From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Subash Patel <subashrp@gmail.com>
Cc: linux-samsung-soc@vger.kernel.org
Subject: Re: enabling FIMC from default config
Date: Mon, 10 Oct 2011 12:16:43 +0200 [thread overview]
Message-ID: <4E92C60B.2040607@samsung.com> (raw)
In-Reply-To: <4E92994E.10601@gmail.com>
Hi Subash,
On 10/10/2011 09:05 AM, Subash Patel wrote:
> I forgot to add:
>
> instead of choosing them through config MACH_**** in arch/arm/mach-exynos4/Kconfig
>
> Regards,
> Subash
>
> On 10/10/2011 12:20 PM, Subash Patel wrote:
>> Hi Sylwester,
>>
>> In the file arch/arm/plat-s5p/Kconfig, why dont we change the below
>>
>> config S5P_DEV_FIMC0/1/2/3
>> bool
>> help
>> Compile in platform device definitions for FIMC controller 0/1/2/3
>>
>> as
>>
>> config S5P_DEV_FIMC0/1/2/3
>> bool
>> depends on VIDEO_SAMSUNG_S5P_FIMC
>> default y
>> help
>> Compile in platform device definitions for FIMC controller 0/1/2/3
>>
>> I find that every time I need to use FIMC, I need to make some
>> un-necessary hacks into Kconfig, even though I choose the menu item
>> "Samsung S5P and EXYNOS4 camera host interface driver"
I'm all for automating these things, although please note plat-s5p/Kconfig
is for all relevant mach-* and the number of available FIMC instances
is specific to each mach-*. E.g. s5pv210 has only 3 instances, while
on exynos4 there are 4. So each mach-* currently selects S5P_DEV_FIMC?.
I agree the current scheme might not be the most optimal.
I'm open to any suggestions on this.
Regards,
--
Sylwester Nawrocki
Samsung Poland R&D Center
prev parent reply other threads:[~2011-10-10 10:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 6:50 enabling FIMC from default config Subash Patel
2011-10-10 7:05 ` Subash Patel
2011-10-10 10:16 ` Sylwester Nawrocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E92C60B.2040607@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=subashrp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.