From: Lars-Peter Clausen <lars@metafoo.de>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: Michael Hennerich <michael.hennerich@analog.com>,
linux-iio@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org
Subject: Re: [PATCH] staging:iio:dac Add AD5064 driver
Date: Mon, 10 Oct 2011 16:39:22 +0200 [thread overview]
Message-ID: <4E93039A.7010401@metafoo.de> (raw)
In-Reply-To: <4E92AFC6.4060108@cam.ac.uk>
On 10/10/2011 10:41 AM, Jonathan Cameron wrote:
> On 10/07/11 20:18, Lars-Peter Clausen wrote:
>> I wanted to use the bulk regulator API at first but decided against it, so we
>> can support the case where only some, but not all, of the channels are used and
>> some channels don't have a supply for their vref.
> That would be fair enough if you were actually supporting the ability to do that
> in the driver. You aren't, so please use the bulk apis.
> If this is added later, then that is the time to hand roll a custom version of this.
Well, the idea was to be consistent with other DAC drivers, which simply
report a
scale value of 0 if no vref was specified. But I'll change it to use the
bulk
regulator API and let probe fail in case a vref regulator is missing.
- Lars
next prev parent reply other threads:[~2011-10-10 14:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 11:08 [PATCH] staging:iio:dac Add AD5064 driver Lars-Peter Clausen
2011-10-07 12:24 ` Jonathan Cameron
2011-10-07 19:18 ` Lars-Peter Clausen
2011-10-10 8:41 ` Jonathan Cameron
2011-10-10 14:39 ` Lars-Peter Clausen [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-10-13 11:40 Lars-Peter Clausen
2011-10-14 14:22 ` Jonathan Cameron
2011-10-14 14:52 ` Lars-Peter Clausen
2011-10-17 7:38 Lars-Peter Clausen
2011-10-17 22:39 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E93039A.7010401@metafoo.de \
--to=lars@metafoo.de \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.