All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Wolfgang Grandegger <wg@grandegger.com>
Cc: Andre Naujoks <nautsch@gmail.com>,
	Wolfram Sang <w.sang@pengutronix.de>,
	Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [PATCH net] mscan: zero accidentally copied register content
Date: Mon, 10 Oct 2011 18:38:55 +0200	[thread overview]
Message-ID: <4E931F9F.3040307@hartkopp.net> (raw)
In-Reply-To: <4E8DF24E.5030606@grandegger.com>

On 10/06/11 20:24, Wolfgang Grandegger wrote:


> Well, copying just the relevant bytes seem much more straight-forward
> than removing accidentally copied bytes later-on. You do not need to
> care about little endian. The MSCAN is only available on PowerPC SOCs,
> which are big endian.
> 
> I'm going to test and post a patch tomorrow.


Thanks.

My patch is then superseded by this one

"mscan: too much data copied to CAN frame due to 16 bit accesses"

http://patchwork.ozlabs.org/patch/118364/

Tnx,
Oliver

  reply	other threads:[~2011-10-10 16:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-05 15:34 [PATCH net] mscan: zero accidentally copied register content Oliver Hartkopp
2011-10-05 15:51 ` Wolfram Sang
2011-10-05 16:10   ` Oliver Hartkopp
2011-10-06  7:02     ` Oliver Hartkopp
2011-10-06  9:09       ` Wolfgang Grandegger
2011-10-06  9:24         ` Wolfram Sang
2011-10-06 14:01           ` Oliver Hartkopp
2011-10-06 14:09             ` Wolfram Sang
2011-10-06 14:14               ` Andre Naujoks
2011-10-06 14:33         ` Oliver Hartkopp
2011-10-06 15:03           ` Andre Naujoks
2011-10-06 18:24             ` Wolfgang Grandegger
2011-10-10 16:38               ` Oliver Hartkopp [this message]
2011-10-06 18:25 ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E931F9F.3040307@hartkopp.net \
    --to=socketcan@hartkopp.net \
    --cc=nautsch@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=w.sang@pengutronix.de \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.