All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Lehmann <Jens.Lehmann@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Tay Ray Chuan <rctay89@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] submodule: whitespace fix
Date: Mon, 10 Oct 2011 20:52:15 +0200	[thread overview]
Message-ID: <4E933EDF.6020909@web.de> (raw)
In-Reply-To: <1317978295-4796-1-git-send-email-rctay89@gmail.com>

Am 07.10.2011 11:04, schrieb Tay Ray Chuan:
> Replace SPs with TAB.

As these are the only lines where spaces are used for indentation in this
file this might be a worthwhile cleanup, but I really don't care that much.
Junio, what do you think?

> Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
> ---
>  git-submodule.sh |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/git-submodule.sh b/git-submodule.sh
> index 928a62f..ebea35b 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -104,9 +104,9 @@ module_name()
>  	re=$(printf '%s\n' "$1" | sed -e 's/[].[^$\\*]/\\&/g')
>  	name=$( git config -f .gitmodules --get-regexp '^submodule\..*\.path$' |
>  		sed -n -e 's|^submodule\.\(.*\)\.path '"$re"'$|\1|p' )
> -       test -z "$name" &&
> -       die "$(eval_gettext "No submodule mapping found in .gitmodules for path '\$path'")"
> -       echo "$name"
> +	test -z "$name" &&
> +	die "$(eval_gettext "No submodule mapping found in .gitmodules for path '\$path'")"
> +	echo "$name"
>  }
>  
>  #

      parent reply	other threads:[~2011-10-10 18:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-07  9:04 [PATCH 1/2] submodule: whitespace fix Tay Ray Chuan
2011-10-07  9:04 ` [PATCH 2/2] submodule::module_clone(): silence die() message from module_name() Tay Ray Chuan
2011-10-10 19:34   ` Jens Lehmann
2011-10-11  8:44     ` Tay Ray Chuan
2011-10-11 17:38       ` Jens Lehmann
2011-10-21 13:49   ` [PATCH v2 0/2] submodule patches Tay Ray Chuan
2011-10-21 13:49     ` [PATCH v2 1/2] submodule: whitespace fix Tay Ray Chuan
2011-10-21 13:49       ` [PATCH v2 2/2] submodule::module_clone(): silence die() message from module_name() Tay Ray Chuan
2011-10-10 18:52 ` Jens Lehmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E933EDF.6020909@web.de \
    --to=jens.lehmann@web.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=rctay89@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.