From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Cousson, Benoit" Subject: Re: [PATCH 1/5 v13] arm: omap: usb: ehci and ohci hwmod structures for omap4 Date: Tue, 11 Oct 2011 10:01:54 +0200 Message-ID: <4E93F7F2.5090805@ti.com> References: <1317901099-2519-1-git-send-email-keshava_mgowda@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Paul Walmsley Cc: "Munegowda, Keshava" , "linux-usb@vger.kernel.org" , "linux-omap@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Balbi, Felipe" , "Hilman, Kevin" , "Gadiyar, Anand" , "sameo@linux.intel.com" , "parthab@india.ti.com" , "tony@atomide.com" , "johnstul@us.ibm.com" , "Sripathy, Vishwanath" List-Id: linux-omap@vger.kernel.org Hi Paul, On 10/11/2011 2:40 AM, Paul Walmsley wrote: > Hi > > and some comments on this one ... > > On Thu, 6 Oct 2011, Keshava Munegowda wrote: [...] >> +static struct omap_hwmod_ocp_if omap44xx_l4_cfg__usb_tll_hs = { >> + .master =&omap44xx_l4_cfg_hwmod, >> + .slave =&omap44xx_usb_tll_hs_hwmod, >> + .addr = omap44xx_usb_tll_hs_addrs, >> + .user = OCP_USER_MPU | OCP_USER_SDMA, >> +}; > > This one has the .master pointing to something reasonable, but is missing > a .clk entry. In that case, there is only an interface clock and a couple of optional clocks, that why I did not populate the main_clk. IIRC, we decided to not duplicate the iclk into the main_clk in case of module that are using only the interface clock as their functional clock. Regards, Benoit