From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <4E942E6C.4080001@metafoo.de> Date: Tue, 11 Oct 2011 13:54:20 +0200 From: Lars-Peter Clausen MIME-Version: 1.0 To: Jonathan Cameron CC: linux-iio@vger.kernel.org, Device-drivers-devel@blackfin.uclinux.org Subject: Re: [PATCH] staging:iio: fix removal path to allow correct freeing. References: <1318259876-7572-1-git-send-email-jic23@cam.ac.uk> <1318259876-7572-2-git-send-email-jic23@cam.ac.uk> <4E932051.2070205@cam.ac.uk> <4E941167.8060403@cam.ac.uk> In-Reply-To: <4E941167.8060403@cam.ac.uk> Content-Type: text/plain; charset=ISO-8859-1 List-ID: On 10/11/2011 11:50 AM, Jonathan Cameron wrote: > On 10/10/11 17:41, Jonathan Cameron wrote: >> On 10/10/11 16:17, Jonathan Cameron wrote: >>> Fix a dumb lack of consideration of the effect of combining >>> the iio_device_unregister and iio_free_device calls into >>> one. There is no valid place to free some of the sysfs >>> array elements. >> My continued testing indicates another dragon hiding somewhere. >> It's of the that lovely type that causes segfaults scattered >> all over the kernel. Will continue tomorrow. > One dragon found. Stupid size of available_scanmasks bug > on allocation in max1363. I'll send a patch out later. > > Now I can hammer probe and remove without problem. > > Testing from others of this patch would be welcomed. > > Jonathan It seems to work fine under normal conditions, but I'm wondering if it is possible to create a sitution in which we still have reference to the iio device pending when we unbind the parent device. In this case iio_free_device would be called before iio_release_device. - Lars