[PATCH] nestedsvm: fix HSAVE_PA MSR

[PATCH] nestedsvm: fix HSAVE_PA MSR

[Christoph Egger]

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]


Accessing HSAVE_PA MSR does not require SVM to be enabled nor any
special guest paging mode.
But accessing HSAVE_PA MSR requires the address to be 4k aligned.

Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

[-- Attachment #2: xen_hsavepa.diff --]
[-- Type: text/plain, Size: 523 bytes --]

diff -r a1fcb77b2ccb xen/arch/x86/hvm/svm/nestedsvm.c
--- a/xen/arch/x86/hvm/svm/nestedsvm.c	Fri Sep 09 10:22:40 2011 +0200
+++ b/xen/arch/x86/hvm/svm/nestedsvm.c	Tue Oct 11 15:56:44 2011 +0200
@@ -51,7 +51,8 @@ nestedsvm_vcpu_stgi(struct vcpu *v)
 static int
 nestedsvm_vmcb_isvalid(struct vcpu *v, uint64_t vmcxaddr)
 {
-    if ( !hvm_svm_enabled(v) || hvm_guest_x86_mode(v) < 2 )
+    /* Address must be 4k aligned */
+    if ( (vmcxaddr & ~PAGE_MASK) != 0 )
         return 0;
 
     /* Maximum valid physical address.

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] nestedsvm: fix HSAVE_PA MSR

[Tim Deegan]

At 15:57 +0200 on 11 Oct (1318348653), Christoph Egger wrote:
> Accessing HSAVE_PA MSR does not require SVM to be enabled nor any
> special guest paging mode.
> But accessing HSAVE_PA MSR requires the address to be 4k aligned.
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>

Applied, thanks.

Tim.