All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Jackson <ajax@redhat.com>
To: Keith Packard <keithp@keithp.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: always set FDI composite sync bit
Date: Tue, 11 Oct 2011 10:10:24 -0400	[thread overview]
Message-ID: <4E944E50.1070903@redhat.com> (raw)
In-Reply-To: <yunty7gtot6.fsf@aiko.keithp.com>

On 10/10/11 7:22 PM, Keith Packard wrote:
> On Mon, 10 Oct 2011 14:28:52 -0700, Jesse Barnes<jbarnes@virtuousgeek.org>  wrote:
>
>> It's needed for 3 pipe support as well as just regular functionality
>> (e.g. DisplayPort).
>
> Any explanation on how you get sync without this? As in, why did this
> ever work?

To a first approximation, it didn't.  I was never able to get anything 
reliably lit up besides the boot output (and only that one; hotplug 
after was a disaster).

I don't have register dumps handy to compare BIOS setup with this 
change, but I could if needed.

It still seems entirely magical and probably wrong in some situations. 
And I'm thrilled to see that PPT is functionally different from CPT 
(seriously, stop doing that) instead of just moving bit definitions 
around (seriously, stop doing that).  But this change is massively 
better than before.

- ajax

  reply	other threads:[~2011-10-11 14:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-10 21:28 [PATCH] drm/i915: always set FDI composite sync bit Jesse Barnes
2011-10-10 21:53 ` Adam Jackson
2011-10-10 22:49 ` Eugeni Dodonov
2011-10-10 23:22 ` Keith Packard
2011-10-11 14:10   ` Adam Jackson [this message]
2011-10-11 16:16     ` Jesse Barnes
2011-10-11 16:42       ` Adam Jackson
2011-10-11 17:38         ` Jesse Barnes
2011-10-11 16:40     ` Jesse Barnes
2011-10-11 17:26       ` Keith Packard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E944E50.1070903@redhat.com \
    --to=ajax@redhat.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=keithp@keithp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.