From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Jackson Subject: Re: [PATCH] drm/i915: always set FDI composite sync bit Date: Tue, 11 Oct 2011 12:42:22 -0400 Message-ID: <4E9471EE.9080201@redhat.com> References: <1318282132-8104-1-git-send-email-jbarnes@virtuousgeek.org> <4E944E50.1070903@redhat.com> <20111011091649.784c9545@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTP id 2CBED9E73D for ; Tue, 11 Oct 2011 10:33:24 -0700 (PDT) In-Reply-To: <20111011091649.784c9545@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On 10/11/11 12:16 PM, Jesse Barnes wrote: > On Tue, 11 Oct 2011 10:10:24 -0400 Adam Jackson wrote: >> It still seems entirely magical and probably wrong in some situations. >> And I'm thrilled to see that PPT is functionally different from CPT >> (seriously, stop doing that) instead of just moving bit definitions >> around (seriously, stop doing that). But this change is massively >> better than before. > > Without composite sync, FDI needs frame/line sync (the fsync/lsync > mentioned in the docs), which means extra wires between the CPU and > PCH. Some boards don't have these and so we need to use composite. > For the same reason, if FDI B and C are sharing lanes, we need to use > composite or we won't have enough lines to go around. > > I've asked the hardware guys whether using composite on a board that > supports fsync/lsync is ok generally; if so just defaulting to that > everywhere should be fine. Makes sense. If true this seems worth doing for CPT too. The IBX docs don't make any mention of composite sync. - ajax