From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gao feng Subject: Re: [PATCH] netconsole: enable netconsole can make net_device refcnt Date: Wed, 12 Oct 2011 09:45:55 +0800 Message-ID: <4E94F153.2070105@cn.fujitsu.com> References: <4E93E238.7000105@cn.fujitsu.com> <1318319438-7159-1-git-send-email-gaowanlong@cn.fujitsu.com> <4E93F8DC.5080909@cn.fujitsu.com> <20111011221148.2ef4487d@asterix.rh> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Wanlong Gao , netdev@vger.kernel.org, davem@davemloft.net To: Flavio Leitner Return-path: Received: from [222.73.24.84] ([222.73.24.84]:58118 "EHLO song.cn.fujitsu.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750980Ab1JLBp7 (ORCPT ); Tue, 11 Oct 2011 21:45:59 -0400 In-Reply-To: <20111011221148.2ef4487d@asterix.rh> Sender: netdev-owner@vger.kernel.org List-ID: 12.10.2011 09:11, Flavio Leitner wrote: > On Tue, 11 Oct 2011 16:05:48 +0800 > Gao feng wrote: > >> Im so sorry. >> the first patch has some format err. >> Please use this one. >> thanks wanlong! ^V^ >> >> 11.10.2011 15:50, Wanlong Gao wrote: >>> There is no check if netconsole is enabled current. >>> so when exec echo 1 > enabled; >>> the reference of net_device will increment always. >>> >>> Signed-off-by: Gao feng >>> --- >>> drivers/net/netconsole.c | 2 ++ >>> 1 files changed, 2 insertions(+), 0 deletions(-) >>> >>> diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c >>> index ed2a397..4e6323df 100644 >>> --- a/drivers/net/netconsole.c >>> +++ b/drivers/net/netconsole.c >>> @@ -307,6 +307,8 @@ static ssize_t store_enabled(struct >>> netconsole_target *nt, return err; >>> if (enabled < 0 || enabled > 1) >>> return -EINVAL; >>> + if (enabled == nt->enabled) >>> + return err; > > It looks like 'err' will be 0. Maybe it is better to > return -EINVAL? > > fbl > Yes,you are right,and I will add some printk.thanks.