All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio M. Di Nitto <fdinitto@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] rgmanager: Resolve rare deadlock [RHEL5]
Date: Wed, 12 Oct 2011 08:38:22 +0200	[thread overview]
Message-ID: <4E9535DE.7060401@redhat.com> (raw)
In-Reply-To: <1318357824-28404-1-git-send-email-lhh@redhat.com>

ACK.

On 10/11/2011 8:30 PM, Lon Hohberger wrote:
> In very rare cases, it was possible to fill up a pipe used for
> IPC between threads during reconfiguration, causing a deadlock.
> This patch resolves the issue.
> 
> Resolves: rhbz#713243
> 
> Signed-off-by: Lon Hohberger <lhh@redhat.com>
> ---
>  rgmanager/src/daemons/groups.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/rgmanager/src/daemons/groups.c b/rgmanager/src/daemons/groups.c
> index b546421..1e93e03 100644
> --- a/rgmanager/src/daemons/groups.c
> +++ b/rgmanager/src/daemons/groups.c
> @@ -1737,8 +1737,6 @@ init_resource_groups(int reconfigure, int do_init, int new_config_version)
>  		free(val);
>  	}
>  
> -	/* Wait for any pending requests */
> -	rg_wait_threads();
>  	/* Block operations that would break during configuration
>  	   changes */
>  	rg_clear_initialized(FL_CONFIG);



      reply	other threads:[~2011-10-12  6:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-11 18:30 [Cluster-devel] [PATCH] rgmanager: Resolve rare deadlock [RHEL5] Lon Hohberger
2011-10-12  6:38 ` Fabio M. Di Nitto [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E9535DE.7060401@redhat.com \
    --to=fdinitto@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.