From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio M. Di Nitto Date: Wed, 12 Oct 2011 08:38:22 +0200 Subject: [Cluster-devel] [PATCH] rgmanager: Resolve rare deadlock [RHEL5] In-Reply-To: <1318357824-28404-1-git-send-email-lhh@redhat.com> References: <1318357824-28404-1-git-send-email-lhh@redhat.com> Message-ID: <4E9535DE.7060401@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit ACK. On 10/11/2011 8:30 PM, Lon Hohberger wrote: > In very rare cases, it was possible to fill up a pipe used for > IPC between threads during reconfiguration, causing a deadlock. > This patch resolves the issue. > > Resolves: rhbz#713243 > > Signed-off-by: Lon Hohberger > --- > rgmanager/src/daemons/groups.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/rgmanager/src/daemons/groups.c b/rgmanager/src/daemons/groups.c > index b546421..1e93e03 100644 > --- a/rgmanager/src/daemons/groups.c > +++ b/rgmanager/src/daemons/groups.c > @@ -1737,8 +1737,6 @@ init_resource_groups(int reconfigure, int do_init, int new_config_version) > free(val); > } > > - /* Wait for any pending requests */ > - rg_wait_threads(); > /* Block operations that would break during configuration > changes */ > rg_clear_initialized(FL_CONFIG);