* [Cluster-devel] [PATCH] rgmanager: Resolve rare deadlock [RHEL5]
@ 2011-10-11 18:30 Lon Hohberger
2011-10-12 6:38 ` Fabio M. Di Nitto
0 siblings, 1 reply; 2+ messages in thread
From: Lon Hohberger @ 2011-10-11 18:30 UTC (permalink / raw)
To: cluster-devel.redhat.com
In very rare cases, it was possible to fill up a pipe used for
IPC between threads during reconfiguration, causing a deadlock.
This patch resolves the issue.
Resolves: rhbz#713243
Signed-off-by: Lon Hohberger <lhh@redhat.com>
---
rgmanager/src/daemons/groups.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/rgmanager/src/daemons/groups.c b/rgmanager/src/daemons/groups.c
index b546421..1e93e03 100644
--- a/rgmanager/src/daemons/groups.c
+++ b/rgmanager/src/daemons/groups.c
@@ -1737,8 +1737,6 @@ init_resource_groups(int reconfigure, int do_init, int new_config_version)
free(val);
}
- /* Wait for any pending requests */
- rg_wait_threads();
/* Block operations that would break during configuration
changes */
rg_clear_initialized(FL_CONFIG);
--
1.7.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Cluster-devel] [PATCH] rgmanager: Resolve rare deadlock [RHEL5]
2011-10-11 18:30 [Cluster-devel] [PATCH] rgmanager: Resolve rare deadlock [RHEL5] Lon Hohberger
@ 2011-10-12 6:38 ` Fabio M. Di Nitto
0 siblings, 0 replies; 2+ messages in thread
From: Fabio M. Di Nitto @ 2011-10-12 6:38 UTC (permalink / raw)
To: cluster-devel.redhat.com
ACK.
On 10/11/2011 8:30 PM, Lon Hohberger wrote:
> In very rare cases, it was possible to fill up a pipe used for
> IPC between threads during reconfiguration, causing a deadlock.
> This patch resolves the issue.
>
> Resolves: rhbz#713243
>
> Signed-off-by: Lon Hohberger <lhh@redhat.com>
> ---
> rgmanager/src/daemons/groups.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/rgmanager/src/daemons/groups.c b/rgmanager/src/daemons/groups.c
> index b546421..1e93e03 100644
> --- a/rgmanager/src/daemons/groups.c
> +++ b/rgmanager/src/daemons/groups.c
> @@ -1737,8 +1737,6 @@ init_resource_groups(int reconfigure, int do_init, int new_config_version)
> free(val);
> }
>
> - /* Wait for any pending requests */
> - rg_wait_threads();
> /* Block operations that would break during configuration
> changes */
> rg_clear_initialized(FL_CONFIG);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-12 6:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-11 18:30 [Cluster-devel] [PATCH] rgmanager: Resolve rare deadlock [RHEL5] Lon Hohberger
2011-10-12 6:38 ` Fabio M. Di Nitto
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.