From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Sangwook Lee <sangwook.lee@linaro.org>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath6kl: fix firmware start address for ar6003 hw2.0
Date: Wed, 12 Oct 2011 10:20:59 +0300 [thread overview]
Message-ID: <4E953FDB.9090709@qca.qualcomm.com> (raw)
In-Reply-To: <1317906725-31130-1-git-send-email-sangwook.lee@linaro.org>
On 10/06/2011 04:12 PM, Sangwook Lee wrote:
> From: Kalle Valo <kvalo@qca.qualcomm.com>
>
> Sangwook found out that commit 639d0b89 ("ath6kl: read firmware start
> address from hardware") broke firmware boot on ar6003 hw2.0 as it seems
> it's not posible to automatically query the address from hardware. So
> we need to hardcode the address for hw2.0.
>
> Reported-by: Sangwook Lee <sangwook.lee@linaro.org>
> Tested-by: Sangwook Lee <sangwook.lee@linaro.org>
> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
> ---
> Kalle:
> I slightly changed again. without running ath6kl_bmi_read() before,
> ath6kl_bmi_execute() failed with hw2.0 board, but I am not clear about this reason.
Hmm, that's strange. I didn't find any reason why this is needed.
> @@ -1201,25 +1202,28 @@ static int ath6kl_upload_otp(struct ath6kl *ar)
> }
>
> /* read firmware start address */
> - ret = ath6kl_bmi_read(ar,
> - ath6kl_get_hi_item_addr(ar,
> - HI_ITEM(hi_app_start)),
> - (u8 *) &address, sizeof(address));
> + ret = ath6kl_bmi_read(ar, ath6kl_get_hi_item_addr(ar,
> + HI_ITEM(hi_app_start)), (u8 *) &address, sizeof(address));
You just change indentation here, right? So this part can be dropped.
I have applied to ath6kl.git now. Thank you very much for your help!
Kalle
next prev parent reply other threads:[~2011-10-12 7:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 13:12 [PATCH] ath6kl: fix firmware start address for ar6003 hw2.0 Sangwook Lee
2011-10-12 7:20 ` Kalle Valo [this message]
2011-10-12 10:45 ` Sangwook Lee
2011-10-13 6:25 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E953FDB.9090709@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sangwook.lee@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.