All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Schnelle <svens@stackframe.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] AVR32: use generic mmc framework
Date: Wed, 12 Oct 2011 16:51:17 +0200	[thread overview]
Message-ID: <4E95A965.20504@stackframe.org> (raw)
In-Reply-To: <4E95A464.5070208@gmail.com>

On 10/12/2011 04:29 PM, Andreas Bie?mann wrote:
> Dear Sven,
>
> Am 12.10.2011 15:09, schrieb Sven Schnelle:
>> gen_atmel_mci works on AVR32 as well, so no need to use the legacy
>> mmc driver. This also has the nice side effect of being able to use
>> SDHC cards an AVR32 boards.
>>
>> Signed-off-by: Sven Schnelle<svens@stackframe.org>
> I have to NACK this patch cause it produces new compile warnings.
>
> $ PATH=$AVR32_PATH:$PATH BUILD_DIR=/tmp/build_uboot BUILD_NCPU=8
> ./MAKEALL atstk1002
> Configuring for atstk1002 board...
> board.c: In function 'board_init_r':
> board.c:338: warning: implicit declaration of function 'mmc_initialize'
> atstk1000.c: In function 'board_mmc_init':
> atstk1000.c:147: warning: implicit declaration of function 'atmel_mci_init'
>     text	   data	    bss	    dec	    hex	filename
>   106091	   7504	 211676	 325271	  4f697	/tmp/build_uboot/u-boot

Oops. Should be easily fixable.

> --------------------- SUMMARY ----------------------------
> Boards compiled: 1
> Boards with warnings or errors: 1 ( atstk1002 )
> ----------------------------------------------------------
>
> And does not work on device:
>
> a) mmc init is not known? Is this not longer necessar
'mmc init' is only available if CONFIG_GENERIC_MMC isn't set, at least
that's how i unterstand the source code. (See common/cmd_mmc.c:29)


> b) ext2ls is not reliable:
>
> ---8<---
> U-Boot>  ext2ls mmc 0:1
> <DIR>        1024 .
> <DIR>        1024 ..
> <DIR>       12288 lost+found
> gen_atmel_mci: CMDR 00051051 (17) ARGR 02008600 (SR: 00400025) Data
> Transfer Failed
>   ** ext2fs_devread read error - last part
> U-Boot>
> --->8---
Hmm, that's really bad. What type of card is this? MMC, SD or SDHC?

Regards
Sven

  reply	other threads:[~2011-10-12 14:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-12 13:09 [U-Boot] [PATCH] AVR32: switch to generic mmc framework Sven Schnelle
2011-10-12 13:09 ` [U-Boot] [PATCH 1/2] AVR32: use " Sven Schnelle
2011-10-12 14:29   ` Andreas Bießmann
2011-10-12 14:51     ` Sven Schnelle [this message]
2011-10-12 14:59       ` Andreas Bießmann
2011-10-12 15:08         ` Sven Schnelle
2011-10-12 15:18           ` Andreas Bießmann
2011-10-14 12:30             ` Andreas Bießmann
2011-10-13  7:52         ` Sven Schnelle
2011-10-12 17:54       ` Wolfgang Denk
2011-10-13  7:45         ` Sven Schnelle
2011-10-12 13:09 ` [U-Boot] [PATCH 2/2] AVR32: remove old atmel_mci driver Sven Schnelle
2011-10-12 17:01 ` [U-Boot] [PATCH] AVR32: switch to generic mmc framework Reinhard Meyer
2011-10-13  8:04   ` Andreas Bießmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E95A965.20504@stackframe.org \
    --to=svens@stackframe.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.