From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49082) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RE1OY-0007k3-UL for qemu-devel@nongnu.org; Wed, 12 Oct 2011 12:11:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RE1OW-0002yG-4q for qemu-devel@nongnu.org; Wed, 12 Oct 2011 12:11:02 -0400 Received: from goliath.siemens.de ([192.35.17.28]:34371) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RE1OV-0002xb-SM for qemu-devel@nongnu.org; Wed, 12 Oct 2011 12:11:00 -0400 Message-ID: <4E95BC0F.2050300@siemens.com> Date: Wed, 12 Oct 2011 18:10:55 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4E95BA25.3070804@web.de> In-Reply-To: <4E95BA25.3070804@web.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 16/23] i8259: PREP: Replace pic_intack_read with pic_read_irq List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Blue Swirl , Anthony Liguori , "hpoussin@reactos.org" , qemu-devel On 2011-10-12 18:02, Andreas F=C3=A4rber wrote: > Hello Jan, >=20 > Since the last round of pulls, PReP magically boots again. :) >=20 > Am 07.10.2011 09:19, schrieb Jan Kiszka: >> There is nothing in the i8259 spec that justifies the special >> pic_intack_read. At least the Linux PREP kernels configure the PICs >> properly so that pic_read_irq returns identical values, and setting >> read_reg_select in PIC0 cannot be derived from any special i8259 mode. >> >> So switch ppc_prep to pic_read_irq and drop the now unused PIC code. >=20 > Seems to resolve an existing XXX in the code. >=20 >> CC: Andreas F=C3=A4rber >> Signed-off-by: Jan Kiszka >=20 > Linux is the only thing we can boot with -M prep that I'm aware of, via > -kernel. And the 40p series doesn't use this at all. I see no regressio= n > on my Debian Etch, so I'm fine with the simplification. >=20 > Tested-by: Andreas F=C3=A4rber Thanks! >=20 >> diff --git a/hw/ppc_prep.c b/hw/ppc_prep.c >> index d26049b..6427baa 100644 >> --- a/hw/ppc_prep.c >> +++ b/hw/ppc_prep.c >> @@ -130,7 +130,7 @@ static inline uint32_t _PPC_intack_read(target_phy= s_addr_t addr) >> uint32_t retval =3D 0; >> =20 >> if ((addr & 0xf) =3D=3D 0) >> - retval =3D pic_intack_read(isa_pic); >> + retval =3D pic_read_irq(isa_pic); >=20 > Mind to add the braces while touching it? Will do if I have to repost this series (I hope not...). Jan --=20 Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux