All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: "M. Mohan Kumar" <mohan@in.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] Add opt_set_bool function
Date: Wed, 12 Oct 2011 18:17:48 +0200	[thread overview]
Message-ID: <4E95BDAC.6030308@suse.de> (raw)
In-Reply-To: <1318406014-16911-1-git-send-email-mohan@in.ibm.com>

Am 12.10.2011 09:53, schrieb M. Mohan Kumar:
> In addition to qemu_opt_set function, we need a function to set bool value
> also.
>
> Signed-off-by: M. Mohan Kumar<mohan@in.ibm.com>
> ---
>   qemu-option.c |   35 +++++++++++++++++++++++++++++++++++
>   qemu-option.h |    1 +
>   2 files changed, 36 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-option.c b/qemu-option.c
> index 105d760..d6bc908 100644
> --- a/qemu-option.c
> +++ b/qemu-option.c
> @@ -636,6 +636,41 @@ int qemu_opt_set(QemuOpts *opts, const char *name, const char *value)
>       return 0;
>   }
>
> +int qemu_opt_set_bool(QemuOpts *opts, const char *name, int val)

Might it make sense to let qemu_opt_{get,set}_bool() use bool type?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746, AG Nürnberg

  parent reply	other threads:[~2011-10-12 16:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-12  7:53 [Qemu-devel] [PATCH 1/2] Add opt_set_bool function M. Mohan Kumar
2011-10-12  7:53 ` [Qemu-devel] [PATCH V4 2/2] hw/9pfs: Add readonly support for 9p export M. Mohan Kumar
2011-10-12 14:08   ` Aneesh Kumar K.V
2011-10-12 15:31     ` M. Mohan Kumar
2011-10-12 16:17 ` Andreas Färber [this message]
2011-10-14  4:24   ` [Qemu-devel] [PATCH 1/2] Add opt_set_bool function M. Mohan Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E95BDAC.6030308@suse.de \
    --to=afaerber@suse.de \
    --cc=mohan@in.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.