From: Randy Dunlap <rdunlap@xenotime.net>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: linux-iio@vger.kernel.org, greg@kroah.com, Michael.Hennerich@analog.com
Subject: Re: [PATCH] staging:iio: gpio build dependency fixing
Date: Wed, 12 Oct 2011 11:06:23 -0700 [thread overview]
Message-ID: <4E95D71F.800@xenotime.net> (raw)
In-Reply-To: <1318413453-7702-1-git-send-email-jic23@cam.ac.uk>
On 10/12/2011 02:57 AM, Jonathan Cameron wrote:
> Numerous drivers either had pointless includes of gpio.h
> or should have been dependent on GENERIC_GPIO and were not.
> Conversion of ads1210 to use array registration triggered
> build failures that highlighted all was not well.
>
> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
> Reported-by: Randy Dunlap <rdunlap@xenotime.net>
Acked-by: Randy Dunlap <rdunlap@xenotime.net>
Thanks.
> ---
>
> Randy pointed out the issue with ad2s1210 triggered by
> building without GENERIC_GPIO. This motivated a quick
> use of git grep on all the drivers and this patch fixes
> all cases where there should have been a dependency,
> or where they was and shouldn't have been (be it implied
> by gpio.h includes).
>
> One has to wonder what the point in having stubs for the
> array calls is. I'll post on this point separately shortly.
>
> I have no idea what the sca3000 was checking those gpios
> for. It is probably lost somewhere in history but clearly
> doesn't make sense.
>
> Jonathan
> drivers/staging/iio/accel/Kconfig | 1 +
> drivers/staging/iio/accel/adis16204_core.c | 1 -
> drivers/staging/iio/accel/sca3000_core.c | 7 +++----
> drivers/staging/iio/adc/Kconfig | 1 +
> drivers/staging/iio/addac/Kconfig | 1 +
> drivers/staging/iio/dac/ad5504.c | 1 -
> drivers/staging/iio/dac/ad5624r_spi.c | 1 -
> drivers/staging/iio/dac/ad5686.c | 1 -
> drivers/staging/iio/dac/ad5791.c | 1 -
> drivers/staging/iio/gyro/adis16080_core.c | 1 -
> drivers/staging/iio/gyro/adis16260_core.c | 1 -
> drivers/staging/iio/gyro/adxrs450_core.c | 1 -
> drivers/staging/iio/magnetometer/Kconfig | 1 +
> drivers/staging/iio/meter/ade7753.c | 1 -
> drivers/staging/iio/meter/ade7754.c | 1 -
> drivers/staging/iio/meter/ade7758_core.c | 1 -
> drivers/staging/iio/meter/ade7759.c | 1 -
> drivers/staging/iio/meter/ade7854.c | 1 -
> drivers/staging/iio/resolver/Kconfig | 2 ++
> 19 files changed, 9 insertions(+), 17 deletions(-)
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
prev parent reply other threads:[~2011-10-12 18:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 9:57 [PATCH] staging:iio: gpio build dependency fixing Jonathan Cameron
2011-10-12 12:14 ` Hennerich, Michael
2011-10-12 18:06 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E95D71F.800@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=Michael.Hennerich@analog.com \
--cc=greg@kroah.com \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.