From: Gerd Hoffmann <kraxel@redhat.com>
To: Christophe Fergeau <cfergeau@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ps2: migrate ledstate
Date: Thu, 13 Oct 2011 09:49:21 +0200 [thread overview]
Message-ID: <4E969801.9060106@redhat.com> (raw)
In-Reply-To: <20111012164742.GA18741@teriyaki.cdg.redhat.com>
Hi,
> One thing that could be improved after this patch is that the ledstate
> is now present both in spice-input and hw/ps2.c, but I couldn't find
> an easy way to get the ps2 ledstate from spice-input so I left things
> this way for now.
Directly linking ps/2 and spice-input would be wrong anyway as there are
other keyboards (usb) too ...
input.c could cache the ledstate and offer a kbd_get_ledstate function,
so anyone interested in the state doesn't need to keep it itself. That
is a pretty minor thing though IMHO.
cheers,
Gerd
prev parent reply other threads:[~2011-10-13 7:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 16:28 [Qemu-devel] [PATCH] spice-input: migrate ledstate Alon Levy
2011-10-11 18:23 ` Anthony Liguori
2011-10-11 18:30 ` Alon Levy
2011-10-12 7:45 ` Gerd Hoffmann
2011-10-12 16:35 ` [Qemu-devel] [PATCH] ps2: " Christophe Fergeau
2011-10-12 16:42 ` Anthony Liguori
2011-10-12 17:17 ` [Qemu-devel] [PATCHv2] " Christophe Fergeau
2011-10-14 15:44 ` [Qemu-devel] [PATCHv3] " Christophe Fergeau
2011-10-17 9:25 ` Gerd Hoffmann
2011-10-17 10:10 ` Christophe Fergeau
2011-10-12 16:47 ` [Qemu-devel] [PATCH] " Christophe Fergeau
2011-10-13 7:49 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E969801.9060106@redhat.com \
--to=kraxel@redhat.com \
--cc=cfergeau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.