From: Chris Metcalf <cmetcalf@tilera.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] arch/tile update for 3.1
Date: Thu, 13 Oct 2011 08:38:10 -0400 [thread overview]
Message-ID: <4E96DBB2.9020104@tilera.com> (raw)
In-Reply-To: <CA+55aFwLWrurcrjX86wBR_eDurvGnsYGOqORXZZ9vyzdM2Ff2Q@mail.gmail.com>
On 10/13/2011 2:31 AM, Linus Torvalds wrote:
> On Wed, Oct 12, 2011 at 9:49 AM, Chris Metcalf <cmetcalf@tilera.com> wrote:
>> Please pull the following trivial change for 3.1 from:
>>
>> git://github.com/cmetcalf-tilera/linux-tile.git stable
>>
>> This change allows 3.1-rc9 to build for the Tile architecture. A bombing
>> of <asm/atomic.h> to <linux/atomic.h> erroneously modified a couple
>> of places where we were relying on some assembly constants in the tile
>> <asm/atomic.h>. Thanks!
> This is not *at*all* what I get when I pull that branch.
>
> I get a merge and two other commits too.
>
> Not pulled.
Mea culpa. I've fixed the tree, so if you could pull again, it should now
have what the original message described.
No doubt my screwup is just a variant on a story you've heard more than a
few times, but for the record, here's some detail. I saw the extra two
commits, which made no sense to me, so I examined one of the files that the
request-pull message described as different and saw no difference, so I
assumed it was just some minor confusion (maybe due to github vs
kernel.org). Turns out that commit was a duplicate that had been in my
tree since June that I'd forgotten about, and the merge represented git
merging in the same semantic commit from a different tree. So, I've now
rolled back my stable tree to June, re-applied just the patch I wanted you
to pull, and retested the tree -- and confirmed that git request-pull
actually now produces the output in my earlier email.
I'll make sure this doesn't happen again.
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
prev parent reply other threads:[~2011-10-13 12:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 21:49 [GIT PULL] arch/tile update for 3.1 Chris Metcalf
2011-10-13 6:31 ` Linus Torvalds
2011-10-13 12:38 ` Chris Metcalf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E96DBB2.9020104@tilera.com \
--to=cmetcalf@tilera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.