From: Gary Thomas <gary@mlbassoc.com>
To: Enrico <ebutera@users.berlios.de>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Enric Balletbo i Serra <eballetbo@iseebcn.com>,
Javier Martinez Canillas <martinez.javier@gmail.com>
Subject: Re: OMAP3 ISP ghosting
Date: Thu, 13 Oct 2011 06:52:41 -0600 [thread overview]
Message-ID: <4E96DF19.8080702@mlbassoc.com> (raw)
In-Reply-To: <CA+2YH7vaN5Q+AJZp8b9E=7Jumaz-cB191CnYDDXF6ZOt7mZocg@mail.gmail.com>
On 2011-10-13 06:32, Enrico wrote:
> On Thu, Oct 13, 2011 at 1:44 PM, Gary Thomas<gary@mlbassoc.com> wrote:
>> On 2011-10-13 02:42, Enrico wrote:
>>>
>>> On Wed, Oct 12, 2011 at 11:42 PM, Gary Thomas<gary@mlbassoc.com> wrote:
>>>>
>>>> Any ideas on this? My naive attempt (diffs attached) just hangs up.
>>>> These changes disable BT-656 mode in the CCDC and tell the TVP5150
>>>> to output raw YUV 4:2:2 data including all SYNC signals.
>>>
>>> I tried that too, you will need to change many of the is_bt656 into
>>> is_fldmode. For isp configuration it seems that the only difference
>>> between the two is (more or less) just the REC656 register. I made a
>>> hundred attempts and in the end i had a quite working capture (just
>>> not centered) but ghosting always there.
>>>
>>> I made another test and by luck i got a strange thing, look at the
>>> following image:
>>>
>>> http://postimage.org/image/2d610pjk4/
>>>
>>> (It's noisy because of a hardware problem)
>>>
>>> I made it with these changes:
>>>
>>> //ccdc_config_outlineoffset(ccdc, pix.bytesperline, EVENEVEN, 1);
>>> ccdc_config_outlineoffset(ccdc, pix.bytesperline, EVENODD, 1);
>>> //ccdc_config_outlineoffset(ccdc, pix.bytesperline, ODDEVEN, 1);
>>> ccdc_config_outlineoffset(ccdc, pix.bytesperline, ODDODD, 1);
>>>
>>> So you have an image with a field with no offset, and a field with
>>> offsets.
>>>
>>> Now if you look between my thumb and my forefinger behind them there's
>>> a monoscope picture and in one field you can see 2 black squares, in
>>> the other one you can see 3 black squares. So the two field that will
>>> be composing a single image differ very much.
>>>
>>> Now the questions are: is this expected to happen on an analogue video
>>> source and we can't do anything (apart from software deinterlacing)?
>>> is this a problem with tvp5150? Is this a problem with the isp?
>>
>> Yes, there does seem to be significant movement/differences between these
>> two images. Are you saying that these should be the two halves of one frame
>> that would be stitched together by de-interlacing? Perhaps the halves are
>> out of sync and the bottom one of this image really goes with the top of
>> the next (frame13)?
>
> They are two fields that normally will be "merged" into a frame, but
> with those settings i made the isp "expand" (SDOFST) just one of the
> fields.
>
> One possible thing is that, as you say, "the bottom one of this image
> really goes with the top of the next".
>
> But one thing to consider is that it is normal for interlaced video to
> have such "effects", that's why progressive scan was invented.
>
>
>> The ghosting problem is still evident, even in this split image. Notice
>> that every other scan line is really poor - basically junk. When this gets
>> merged as part of the de-interlace, the ghosts appear.
>
> I don't think so. The bottom part is "expanded" by the isp, so it's ok
> to have green half lines, that's where the top part will go if it is
> "expanded" by the isp.
>
> Looking at the single images (top and bottom) i don't see ghosting
> artifacts (not only in that image but in a sequence of 16 frames),
> just a little blurry in moving parts but that's expected in an
> interlaced video. So it seems to me that the images arrive correctly
> at the isp and the deinterlacing causes ghosting.
Is there any way to prove this by doing the de-interlacing in software?
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
next prev parent reply other threads:[~2011-10-13 12:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 13:20 OMAP3 ISP ghosting Gary Thomas
2011-10-12 21:42 ` Gary Thomas
2011-10-13 8:42 ` Enrico
2011-10-13 11:44 ` Gary Thomas
2011-10-13 12:32 ` Enrico
2011-10-13 12:52 ` Gary Thomas [this message]
2011-10-13 13:47 ` Javier Martinez Canillas
2011-10-13 15:38 ` Gary Thomas
2011-10-20 17:45 ` Enrico
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E96DF19.8080702@mlbassoc.com \
--to=gary@mlbassoc.com \
--cc=eballetbo@iseebcn.com \
--cc=ebutera@users.berlios.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=martinez.javier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.