All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Daney <david.daney@cavium.com>
To: Andy Fleming <afleming@freescale.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] net: Allow skb_recycle_check to be done in stages
Date: Thu, 13 Oct 2011 08:35:00 -0700	[thread overview]
Message-ID: <4E970524.2080908@cavium.com> (raw)
In-Reply-To: <1318516435-24314-1-git-send-email-afleming@freescale.com>

On 10/13/2011 07:33 AM, Andy Fleming wrote:
> skb_recycle_check resets the skb if it's eligible for recycling.
> However, there are times when a driver might want to optionally
> manipulate the skb data with the skb before resetting the skb,
> but after it has determined eligibility.  We do this by splitting the
> eligibility check from the skb reset, creating two inline functions to
> accomplish that task.
>
> Signed-off-by: Andy Fleming<afleming@freescale.com>

Acked-by: David Daney <david.daney@cavium.com>

I need this for my (Octeon) Ethernet driver as well.  Currently we have 
an ad hoc driver local implementation of this, but I would like to use 
this core code if possible.




> ---
>
> I found this useful for a driver we're working on where the device can
> do different things, depending on whether the skb is recycleable.
>
>   include/linux/skbuff.h |   21 +++++++++++++++++++
>   net/core/skbuff.c      |   51 ++++++++++++++++++++++++-----------------------
>   2 files changed, 47 insertions(+), 25 deletions(-)
>

[...]

  parent reply	other threads:[~2011-10-13 15:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-13 14:33 [PATCH 1/2] net: Allow skb_recycle_check to be done in stages Andy Fleming
2011-10-13 14:33 ` [PATCH 2/2] phylib: Modify Vitesse RGMII skew settings Andy Fleming
2011-10-19 20:00   ` David Miller
2011-10-13 15:35 ` David Daney [this message]
2011-10-19 20:00 ` [PATCH 1/2] net: Allow skb_recycle_check to be done in stages David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E970524.2080908@cavium.com \
    --to=david.daney@cavium.com \
    --cc=afleming@freescale.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.