Hi Mikel,

On 10/12/2011 07:35 AM, Mikel Astiz wrote:
> According to the HFP specification, inband ringing will be enabled by
> default if the AG supports it. This setting could later be changed by
> the unsolicited result code +BSIR.
> ---
>  drivers/hfpmodem/handsfree.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)

Patch has been applied, however I amended it slightly due to a compiler
error.

> 
> diff --git a/drivers/hfpmodem/handsfree.c b/drivers/hfpmodem/handsfree.c
> index d3b5b44..12a23fc 100644
> --- a/drivers/hfpmodem/handsfree.c
> +++ b/drivers/hfpmodem/handsfree.c
> @@ -44,6 +44,7 @@
>  
>  struct hf_data {
>  	GAtChat *chat;
> +	unsigned int ag_features;
>  };
>  
>  static gboolean hfp_handsfree_register(gpointer user_data)
> @@ -52,6 +53,9 @@ static gboolean hfp_handsfree_register(gpointer user_data)
>  
>  	ofono_handsfree_register(hf);
>  
> +	if (hd->ag_features & HFP_AG_FEATURE_IN_BAND_RING_TONE)
> +		ofono_handsfree_set_inband_ringing(hf, TRUE);
> +

I also moved this part to happen before registering in a later commit.
1 less signal emission to worry about ;)

>  	return FALSE;
>  }
>  
> @@ -64,6 +68,7 @@ static int hfp_handsfree_probe(struct ofono_handsfree *hf,
>  	DBG("");
>  	hd = g_new0(struct hf_data, 1);
>  	hd->chat = g_at_chat_clone(info->chat);
> +	hd->ag_features = info->ag_features;
>  
>  	ofono_handsfree_set_data(hf, hd);
>  

Regards,
-Denis