From mboxrd@z Thu Jan  1 00:00:00 1970
From: Asias He <asias.hejun@gmail.com>
Subject: Re: [PATCH 5/7] kvm tools: Add help and info messages to 'kvm setup'
Date: Fri, 14 Oct 2011 09:02:51 +0800
Message-ID: <4E978A3B.5070608@gmail.com>
References: <1318498366-7824-1-git-send-email-levinsasha928@gmail.com> <1318498366-7824-5-git-send-email-levinsasha928@gmail.com> <20111013100046.GA13651@elte.hu> <alpine.LFD.2.02.1110131938030.2923@tux.localdomain> <20111013165233.GB30861@elte.hu> <CAOJsxLHDSLEV_Kx5TXY0ou0z-jL_Vy7dPpOHW3BO0YEsMmiK+g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Ingo Molnar <mingo@elte.hu>, Sasha Levin <levinsasha928@gmail.com>,
	kvm@vger.kernel.org, gorcunov@gmail.com
To: Pekka Enberg <penberg@cs.helsinki.fi>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-yw0-f46.google.com ([209.85.213.46]:42505 "EHLO
	mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932065Ab1JNBDc (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 13 Oct 2011 21:03:32 -0400
Received: by yws29 with SMTP id 29so113033yws.19
        for <kvm@vger.kernel.org>; Thu, 13 Oct 2011 18:03:32 -0700 (PDT)
In-Reply-To: <CAOJsxLHDSLEV_Kx5TXY0ou0z-jL_Vy7dPpOHW3BO0YEsMmiK+g@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 10/14/2011 02:22 AM, Pekka Enberg wrote:
> On Thu, Oct 13, 2011 at 7:52 PM, Ingo Molnar <mingo@elte.hu> wrote:
>>>> Btw., will 'kvm run' select the last-created rootfs by default?
>>>
>>> No, it runs rootfs that's named 'default'. We can change that but
>>> I'm not completely convinced running that last-created rootfs is
>>> the right thing to do here. Hmm.
>>
>> I'm not convinced either - just wanted to raise the issue.
> 
> Right. So 'kvm run' is supposed to setup and launch a 'default' rootfs
> if no rootfs is specified.
> 
>> Also, i raised this in the other thread, why not use .kvmtool of the
>> current directory? That way it's cwd local like Git and perf. A 'kvm
>> run' (union?) mount the cwd or so - so this would be a natural
>> equivalent to chroot. The $HOME/.kvmtool is a Qemu-ish global
>> workflow.
> 
> Yeah, that definitely makes sense. 'kvm setup rootfs' wouldn't create
> rootfs under $HOME/.kvmtool/rootfs but under $(PWD)/rootfs.

I also think $(PWD)/rootfs is much better than $HOME/.kvmtool/rootfs.
I think 'kvm setup $absolute_rootfs_path' make sense as well.

> I guess we'll lose the ability to 'kvm list' all available rootfs
> directories, though?

User can create and put the rootfs directories where he/she likes. We do
not need to track where the rootfs directories is, thus we do not need
to 'kvm list' them.

-- 
Asias He