All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] savevm: qemu_savevm_state(): Drop stop VM logic
Date: Fri, 14 Oct 2011 10:49:30 +0200	[thread overview]
Message-ID: <4E97F79A.1040609@redhat.com> (raw)
In-Reply-To: <20111013172753.3b744c58@doriath>

Am 13.10.2011 22:27, schrieb Luiz Capitulino:
> qemu_savevm_state() has some logic to stop the VM and to (or not to)
> resume it. But this seems to be a big noop, as qemu_savevm_state()
> is only called by do_savevm() when the VM is already stopped.
> 
> So, let's drop qemu_savevm_state()'s stop VM logic.
> 
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>

Reviewed-by: Kevin Wolf <kwolf@redhat.com>

  parent reply	other threads:[~2011-10-14  8:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-13 20:27 [Qemu-devel] [PATCH] savevm: qemu_savevm_state(): Drop stop VM logic Luiz Capitulino
2011-10-14  1:33 ` Michael Roth
2011-10-14  8:49 ` Kevin Wolf [this message]
2011-10-14 11:27 ` Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E97F79A.1040609@redhat.com \
    --to=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.