From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laszlo Ersek Subject: [RFC PATCH] return -EINVAL when trying to kick/kill a nonexistent domain watchdog Date: Fri, 14 Oct 2011 12:02:11 +0200 Message-ID: <4E9808A3.9090501@redhat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------090001020003000609000206" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --------------090001020003000609000206 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit ... to be more in-line with the NR_DOMAIN_WATCHDOG_TIMERS check at the top of domain_watchdog(), and also to follow the timer_(delete|settime) POSIX API's EINVAL return value. Signed-off-by: Laszlo Ersek --------------090001020003000609000206 Content-Type: text/plain; name="einval_upstream.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="einval_upstream.patch" diff -r 4b0907c6a08c xen/common/schedule.c --- a/xen/common/schedule.c Tue Oct 11 12:02:58 2011 +0100 +++ b/xen/common/schedule.c Fri Oct 14 11:55:00 2011 +0200 @@ -763,7 +763,7 @@ static long domain_watchdog(struct domai if ( !test_bit(id, &d->watchdog_inuse_map) ) { spin_unlock(&d->watchdog_lock); - return -EEXIST; + return -EINVAL; } if ( timeout == 0 ) --------------090001020003000609000206 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --------------090001020003000609000206--