All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Andreas Färber" <andreas.faerber@web.de>,
	patches@linaro.org, "Anthony Liguori" <aliguori@us.ibm.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: Detect when glibc implements makecontext() to always fail
Date: Fri, 14 Oct 2011 14:47:25 +0200	[thread overview]
Message-ID: <4E982F5D.40801@redhat.com> (raw)
In-Reply-To: <CAFEAcA9sOA+tbqwy-wZKqmo5ooxaH87PZz=G-mY-+ONrN8Y-=Q@mail.gmail.com>

On 10/14/2011 02:30 PM, Peter Maydell wrote:
> I've also just discovered that it's no use on Oneiric,
> where the linker warning has gone away but the syscall
> still always returns ENOSYS.
>
> I think we should just always use the gthread implementation
> rather than preferring a non-portable-and-hard-to-detect
> set of functions (which increases the set of different
> configs we need to test with). If there's a performance problem
> with that we should get it fixed in gthread:-)

A user-space longjmp will always be slower than a mutex+condvar+context 
switch.  We're talking _orders of magnitude_ slower.  At this point it's 
better to write assembly, since we already support only a dozen TCG targets.

I played with an alternative implementation using a 2-barrier instead of 
mutex+condvar, but it didn't give any speedup and was still much slower 
than gthread.

Paolo

  reply	other threads:[~2011-10-14 12:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-12 16:21 [Qemu-devel] [PATCH] configure: Detect when glibc implements makecontext() to always fail Peter Maydell
2011-10-13 14:26 ` Andreas Färber
2011-10-13 22:23   ` Andreas Färber
2011-10-14 12:30     ` Peter Maydell
2011-10-14 12:47       ` Paolo Bonzini [this message]
2011-10-14 12:55         ` Paolo Bonzini
2011-10-14 13:01           ` Peter Maydell
  -- strict thread matches above, loose matches on Subject: below --
2012-02-23 16:16 Peter Maydell
2012-02-23 16:19 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E982F5D.40801@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=andreas.faerber@web.de \
    --cc=patches@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.