From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/4] block: unify flush implementations
Date: Fri, 14 Oct 2011 15:47:38 +0200 [thread overview]
Message-ID: <4E983D7A.6020208@redhat.com> (raw)
In-Reply-To: <20111014132002.GA1486@stefanha-thinkpad.localdomain>
On 10/14/2011 03:20 PM, Stefan Hajnoczi wrote:
> It's just too tempting to call these functions in contexts where it is
> not okay to do so. The bdrv_co_*() functions are all tagged as
> coroutine_fn and make it clear that they can yield.
Yes, I agree.
> We already have an event loop in qemu-img except it's the nested event
> loop in synchronous bdrv_*() emulation functions. The nested event loop
> is a mini event loop and can't really do things like timers. It would
> be nicer to remove it in favor of a single top-level event loop with the
> qemu-img code running in a coroutine.
Note that the nested event loop cannot go away because of
qemu_aio_flush, though. :(
Paolo
next prev parent reply other threads:[~2011-10-14 13:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 8:41 [Qemu-devel] [PATCH 0/4] coroutinization of flush and discard (split out of NBD series) Paolo Bonzini
2011-10-14 8:41 ` [Qemu-devel] [PATCH 1/4] block: rename bdrv_co_rw_bh Paolo Bonzini
2011-10-14 8:41 ` [Qemu-devel] [PATCH 2/4] block: unify flush implementations Paolo Bonzini
2011-10-14 11:08 ` Kevin Wolf
2011-10-14 11:30 ` Paolo Bonzini
2011-10-14 11:54 ` Kevin Wolf
2011-10-14 12:42 ` Paolo Bonzini
2011-10-14 14:02 ` Kevin Wolf
2011-10-14 14:04 ` Paolo Bonzini
2011-10-14 13:20 ` Stefan Hajnoczi
2011-10-14 13:47 ` Paolo Bonzini [this message]
2011-10-14 8:41 ` [Qemu-devel] [PATCH 3/4] block: drop redundant bdrv_flush implementation Paolo Bonzini
2011-10-14 8:41 ` [Qemu-devel] [PATCH 4/4] block: add bdrv_co_discard and bdrv_aio_discard support Paolo Bonzini
2011-10-14 14:23 ` Kevin Wolf
2011-10-14 14:24 ` Paolo Bonzini
2011-10-14 14:32 ` Kevin Wolf
2011-10-14 14:35 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E983D7A.6020208@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.