From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33052) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1REiNP-0006p4-Po for qemu-devel@nongnu.org; Fri, 14 Oct 2011 10:04:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1REiNK-0006rn-5r for qemu-devel@nongnu.org; Fri, 14 Oct 2011 10:04:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39006) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1REiNJ-0006ri-Th for qemu-devel@nongnu.org; Fri, 14 Oct 2011 10:04:38 -0400 Message-ID: <4E984171.9070007@redhat.com> Date: Fri, 14 Oct 2011 16:04:33 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1318581692-18338-1-git-send-email-pbonzini@redhat.com> <1318581692-18338-3-git-send-email-pbonzini@redhat.com> <4E98183E.5040303@redhat.com> <4E981D6D.1070407@redhat.com> <4E982302.1030100@redhat.com> <4E982E2D.1050009@redhat.com> <4E984104.20905@redhat.com> In-Reply-To: <4E984104.20905@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/4] block: unify flush implementations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com On 10/14/2011 04:02 PM, Kevin Wolf wrote: >> > >> > It would still host the checks on BDRV_O_NO_FLUSH and bs->drv->*_flush. >> > It would be the same as bdrv_flush_co_entry is now, minus the >> > marshalling in/out of the RwCo. > Right. > > By the way, I like how you handle all three backends in the same > function. I think this is a lot more readable than the solution used by > read/write (changing the function pointers on driver registration). > Yeah, and it makes sense to handle all of them in the bdrv_co_* version. Will resubmit. Paolo