From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 4/4] block: add bdrv_co_discard and bdrv_aio_discard support
Date: Fri, 14 Oct 2011 16:23:34 +0200 [thread overview]
Message-ID: <4E9845E6.3020905@redhat.com> (raw)
In-Reply-To: <1318581692-18338-5-git-send-email-pbonzini@redhat.com>
Am 14.10.2011 10:41, schrieb Paolo Bonzini:
> This similarly adds support for coroutine and asynchronous discard.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Do we really need bdrv_discard and bdrv_aio_discard in the backends? I
think it makes sense to have a bdrv_aio_discard() in block.h as AIO
generally fits well for device models, but I would just require
bdrv_co_discard for any block drivers implementing discard.
> I was not sure if qcow2 could be changed to co_discard, though
> I suspected yes.
As discussed on IRC: Yes, it just must make sure to take s->lock.
Kevin
next prev parent reply other threads:[~2011-10-14 14:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 8:41 [Qemu-devel] [PATCH 0/4] coroutinization of flush and discard (split out of NBD series) Paolo Bonzini
2011-10-14 8:41 ` [Qemu-devel] [PATCH 1/4] block: rename bdrv_co_rw_bh Paolo Bonzini
2011-10-14 8:41 ` [Qemu-devel] [PATCH 2/4] block: unify flush implementations Paolo Bonzini
2011-10-14 11:08 ` Kevin Wolf
2011-10-14 11:30 ` Paolo Bonzini
2011-10-14 11:54 ` Kevin Wolf
2011-10-14 12:42 ` Paolo Bonzini
2011-10-14 14:02 ` Kevin Wolf
2011-10-14 14:04 ` Paolo Bonzini
2011-10-14 13:20 ` Stefan Hajnoczi
2011-10-14 13:47 ` Paolo Bonzini
2011-10-14 8:41 ` [Qemu-devel] [PATCH 3/4] block: drop redundant bdrv_flush implementation Paolo Bonzini
2011-10-14 8:41 ` [Qemu-devel] [PATCH 4/4] block: add bdrv_co_discard and bdrv_aio_discard support Paolo Bonzini
2011-10-14 14:23 ` Kevin Wolf [this message]
2011-10-14 14:24 ` Paolo Bonzini
2011-10-14 14:32 ` Kevin Wolf
2011-10-14 14:35 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9845E6.3020905@redhat.com \
--to=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.