Re: [PATCH] qt4: Added support for QtMobility 1.2

[Saul Wold <sgw@linux.intel.com>]

On 10/14/2011 08:18 AM, Dmitry Cherukhin wrote:
> On Mon, 2011-09-26 at 16:32 -0700, Saul Wold wrote:
>> On 09/23/2011 07:13 AM, Dmitry Cherukhin wrote:
>>> This patch is indented to add new functionality,
>>> specifically, the patch adds support for
>>> the QtMobility 1.2 package.
>>>
>>> Added two recipes:
>>> 1) qt-mobility-x11 builds the QtMobility 1.2 package
>>>      on the basis of qt4-x11-free;
>>> 2) qt-mobility-embedded builds the QtMobility 1.2 package
>>>      on the basis of qt4-embedded.
>>>
>>> Signed-off-by: Dmitry Cherukhin<dima_ch@emcraft.com>
>>> ---
>>>    meta/recipes-qt/qt4/files/qtm_qtmobility_pro.patch |   28 +++++++++++
>>>    meta/recipes-qt/qt4/files/qtme_gstreamer_pro.patch |   16 ++++++
>>>    meta/recipes-qt/qt4/qt-mobility-embedded_1.2.0.bb  |   13 +++++
>>>    meta/recipes-qt/qt4/qt-mobility-x11_1.2.0.bb       |   11 ++++
>>>    meta/recipes-qt/qt4/qt-mobility_1.2.0.inc          |   51 ++++++++++++++++++++
>>>    5 files changed, 119 insertions(+), 0 deletions(-)
>>>    create mode 100644 meta/recipes-qt/qt4/files/qtm_qtmobility_pro.patch
>>>    create mode 100644 meta/recipes-qt/qt4/files/qtme_gstreamer_pro.patch
>>>    create mode 100644 meta/recipes-qt/qt4/qt-mobility-embedded_1.2.0.bb
>>>    create mode 100644 meta/recipes-qt/qt4/qt-mobility-x11_1.2.0.bb
>>>    create mode 100644 meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
>>>
>>> diff --git a/meta/recipes-qt/qt4/files/qtm_qtmobility_pro.patch b/meta/recipes-qt/qt4/files/qtm_qtmobility_pro.patch
>>> new file mode 100644
>>> index 0000000..689c224
>>> --- /dev/null
>>> +++ b/meta/recipes-qt/qt4/files/qtm_qtmobility_pro.patch
>>> @@ -0,0 +1,28 @@
>>> +This patch fixes the following issue at the configure stage:
>>> +   Project ERROR: Qt Mobility requires Qt 4.6 or higher. Qt was found.
>>> +The version of Qt is already 4.7.3, so this is misconfiguration problem.
>>> +
>>> +The origin of this patch is:
>>> +   http://neophysis.git.sourceforge.net/git/gitweb.cgi?p=neophysis/openembedded;
>>> +   a=blob;f=recipes/neophysis/qt-mobility-1.0.0/qtmobility_pro.patch;
>>> +   h=fc5e1691aed47bc50d87e5c33497354182cacda4;hb=refs/heads/neophysis-testing-0.3
>>> +Upstream-Status: not-appropriate
>>
>> Please refer to wiki page on www.openembedded.org for the corrcet
>> formating of the Upstream-Status field.  You are also missing a
>> Signed-off-by: line for each patch file.
>>
>> (I would give the exact page, but the site appears to be having problems)
>>
>
> Thanks!
> I removed all .patch files, new version of the patch is here:
> http://thread.gmane.org/gmane.comp.handhelds.openembedded.core/8708
>
That's great, but that reader seems to mangle emails in a way that I 
can't use them for patching, it would be great if you could just send 
the v2 to this mailing list.

Thanks
	Sau!

> Dima
>
>