From: Jeff Garzik <jgarzik@pobox.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
David Miller <davem@davemloft.net>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] pata_pcmcia/ide-cs: move IDs table to <linux/pata_pcmcia_ids.h>
Date: Fri, 14 Oct 2011 12:55:36 -0400 [thread overview]
Message-ID: <4E986988.6080106@pobox.com> (raw)
In-Reply-To: <201110131312.14498.bzolnier@gmail.com>
On 10/13/2011 07:12 AM, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com>
> Subject: [PATCH] pata_pcmcia/ide-cs: move IDs table to<linux/pata_pcmcia_ids.h>
>
> Signed-off-by: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com>
> ---
> drivers/ata/pata_pcmcia.c | 74 +---------------------------------------
> drivers/ide/ide-cs.c | 74 +---------------------------------------
> include/linux/pata_pcmcia_ids.h | 70 +++++++++++++++++++++++++++++++++++++
> 3 files changed, 75 insertions(+), 143 deletions(-)
I'm torn... it is an obvious and simple consolidation, but I dislike
dropping such a driver-specific turd in include/linux. I also wonder if
we want to continue adding new IDs to ide-cs?
David, any opinions? I'm basically ok with any option: (a) take Bart's
patch as-is (with your acked-by), (b) ignore the patch and set a
no-new-ids policy for ide-cs, (c) other?
Jeff
next prev parent reply other threads:[~2011-10-14 16:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 11:12 [PATCH] pata_pcmcia/ide-cs: move IDs table to <linux/pata_pcmcia_ids.h> Bartlomiej Zolnierkiewicz
2011-10-13 12:55 ` Alan Cox
2011-10-14 16:55 ` Jeff Garzik [this message]
2011-10-14 18:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E986988.6080106@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.