All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] arm, davinci: Correct the MDSTAT.STATE mask
Date: Sun, 16 Oct 2011 00:34:37 +0400	[thread overview]
Message-ID: <4E99EE5D.5090508@mvista.com> (raw)
In-Reply-To: <1318419080-14396-3-git-send-email-christian.riesch@omicron.at>

Hello.

On 12-10-2011 15:31, Christian Riesch wrote:

> MDSTAT.STATE occupies bits 0..5 according to all available documentation,
> therefore change the bitmask to 0x3f.

> Signed-off-by: Christian Riesch<christian.riesch@omicron.at>
> Cc: Heiko Schocher<hs@denx.de>
> Cc: Paulraj Sandeep<s-paulraj@ti.com>
> Cc: Albert ARIBAUD<albert.u.boot@aribaud.net>
> Cc: Sergei Shtylyov<sshtylyov@ru.mvista.com>
> ---
>   arch/arm/cpu/arm926ejs/davinci/psc.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)

> diff --git a/arch/arm/cpu/arm926ejs/davinci/psc.c b/arch/arm/cpu/arm926ejs/davinci/psc.c
> index 8273a7f..486adb0 100644
> --- a/arch/arm/cpu/arm926ejs/davinci/psc.c
> +++ b/arch/arm/cpu/arm926ejs/davinci/psc.c
> @@ -83,7 +83,7 @@ void lpsc_on(unsigned int id)
>   	while (readl(ptstat)&  0x01)
>   		continue;
>
> -	if ((readl(mdstat)&  0x1f) == 0x03)
> +	if ((readl(mdstat)&  0x3f) == 0x03)
>   		return; /* Already on and enabled */
>
>   	writel(readl(mdctl) | 0x03, mdctl);
> @@ -114,7 +114,7 @@ void lpsc_on(unsigned int id)
>
>   	while (readl(ptstat)&  0x01)
>   		continue;
> -	while ((readl(mdstat)&  0x1f) != 0x03)
> +	while ((readl(mdstat)&  0x3f) != 0x03)
>   		continue;
>   }

    This patch is incomplete but I guess you've figured that out already as 
you've commented on my analogous patch. So marking for the custodian -- don't 
apply this patch.

WBR, Sergei

  reply	other threads:[~2011-10-15 20:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-12 11:31 [U-Boot] [PATCH 0/4] Remove duplicate functions for power and sleep configuration Christian Riesch
2011-10-12 11:31 ` [U-Boot] [PATCH 1/4] arm, davinci: Rename AM1808 lowlevel functions to DA850 Christian Riesch
2011-10-13  5:23   ` Heiko Schocher
2011-10-13  5:37     ` Christian Riesch
2011-10-12 11:31 ` [U-Boot] [PATCH 2/4] arm, davinci: Correct the MDSTAT.STATE mask Christian Riesch
2011-10-15 20:34   ` Sergei Shtylyov [this message]
2011-10-16 17:36     ` Christian Riesch
2011-10-12 11:31 ` [U-Boot] [PATCH 3/4] arm, davinci: Add function lpsc_syncreset() Christian Riesch
2011-10-13  5:42   ` Heiko Schocher
2011-10-13  6:14     ` Christian Riesch
2011-10-12 11:31 ` [U-Boot] [PATCH 4/4] arm, davinci: Remove the duplication of LPSC functions in da850_lowlevel.c Christian Riesch
2011-10-12 11:47 ` [U-Boot] [PATCH 0/4] Remove duplicate functions for power and sleep configuration Christian Riesch
2011-10-13  5:23 ` Heiko Schocher
2011-10-13  6:28   ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E99EE5D.5090508@mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.