From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from re04.intra2net.com ([82.165.46.26]:56252 "EHLO re04.intra2net.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751649Ab1JOVgI (ORCPT ); Sat, 15 Oct 2011 17:36:08 -0400 Message-ID: <4E99FCC4.3090309@intra2net.com> Date: Sat, 15 Oct 2011 23:36:04 +0200 From: Thomas Jarosch MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: linux-media@vger.kernel.org Subject: [PATCH] Fix logic in sanity check Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Detected by "cppcheck". --- drivers/media/video/m5mols/m5mols_core.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/m5mols/m5mols_core.c b/drivers/media/video/m5mols/m5mols_core.c index fb8e4a7..e485e9e 100644 --- a/drivers/media/video/m5mols/m5mols_core.c +++ b/drivers/media/video/m5mols/m5mols_core.c @@ -333,7 +333,7 @@ int m5mols_mode(struct m5mols_info *info, u8 mode) int ret = -EINVAL; u8 reg; - if (mode < REG_PARAMETER && mode > REG_CAPTURE) + if (mode < REG_PARAMETER || mode > REG_CAPTURE) return ret; ret = m5mols_read_u8(sd, SYSTEM_SYSMODE, ®); -- 1.7.6.4