From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RFK1m-0006dC-6x for qemu-devel@nongnu.org; Sun, 16 Oct 2011 02:16:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RFK1l-0003OX-7Z for qemu-devel@nongnu.org; Sun, 16 Oct 2011 02:16:54 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:34753) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RFK1l-0003O0-31 for qemu-devel@nongnu.org; Sun, 16 Oct 2011 02:16:53 -0400 Message-ID: <4E9A769F.1060308@weilnetz.de> Date: Sun, 16 Oct 2011 08:15:59 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1318213565-3268-1-git-send-email-jcmvbkbc@gmail.com> <201110160152.16484.jcmvbkbc@gmail.com> In-Reply-To: <201110160152.16484.jcmvbkbc@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/7] target-xtensa: add overlay parsing header and convert hand-written core definitions to use overlays List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Filippov Cc: Blue Swirl , qemu-devel@nongnu.org Am 15.10.2011 23:52, schrieb Max Filippov: >> On Mon, Oct 10, 2011 at 2:25 AM, Max Filippov wrote: >>> Max Filippov (7): >>> target-xtensa: increase xtensa options accuracy >>> target-xtensa: remove hand-written xtensa cores implementations >>> target-xtensa: implement external interrupt mapping >>> target-xtensa: extract core configuration from overlay >>> target-xtensa: add dc232b core >>> target-xtensa: add fsf core >>> target-xtensa: rename dc232b board to sim >> Patch 4 would add a blank line at EOF, patches 5& 6 have tabs and >> patch 7 does not apply anymore, please fix. > Patches 5& 6 have coding style violations in the autogenerated files not meant to be edited. > Do you really want them fixed? Or you care only about tabs in them? > > Thanks. > -- Max Autogenerated files can be formatted by tools like astyle, then they are still autogenerated. I recently sent an astyle configuration which matches QEMU's coding style to the list. Regards Stefan W.