From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:38441)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1RFkcf-0008TU-GH
	for qemu-devel@nongnu.org; Mon, 17 Oct 2011 06:40:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1RFkcZ-0002Ws-R2
	for qemu-devel@nongnu.org; Mon, 17 Oct 2011 06:40:45 -0400
Received: from mx1.redhat.com ([209.132.183.28]:21426)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1RFkcZ-0002We-J9
	for qemu-devel@nongnu.org; Mon, 17 Oct 2011 06:40:39 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9HAecRC021126
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 17 Oct 2011 06:40:38 -0400
Message-ID: <4E9C06E0.5000600@redhat.com>
Date: Mon, 17 Oct 2011 12:43:44 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1318847534-14357-1-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1318847534-14357-1-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 0/3] coroutinization of flush and
 discard (split out of NBD series)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

Am 17.10.2011 12:32, schrieb Paolo Bonzini:
> This series, applying on top of block branch, enables drivers to use
> coroutines for flush and discard.  I kept aio_discard after discussing
> with Kevin since it should be useful not only for raw-posix-aio, but also
> for the userspace iSCSI backend (and in general for backends relying on
> an external library that is designed around aio).
> 
> BTW, with this patch we get "for free" the invariant that bdrv_aio_*
> never returns a NULL acb (Stefan's patches already got to that point
> for read/write, of course).

Cool, I wasn't aware of that. That's a very nice side effect!

Maybe we should write this down in a comment and remove the now
unnecessary error handling from callers.

Kevin