From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35386) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RFkqM-0002Qb-66 for qemu-devel@nongnu.org; Mon, 17 Oct 2011 06:54:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RFkqL-00054R-2y for qemu-devel@nongnu.org; Mon, 17 Oct 2011 06:54:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26586) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RFkqK-00054N-S0 for qemu-devel@nongnu.org; Mon, 17 Oct 2011 06:54:53 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9HAspSM004558 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 17 Oct 2011 06:54:51 -0400 Message-ID: <4E9C0A35.2060609@redhat.com> Date: Mon, 17 Oct 2011 12:57:57 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1318847534-14357-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1318847534-14357-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/3] coroutinization of flush and discard (split out of NBD series) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org Am 17.10.2011 12:32, schrieb Paolo Bonzini: > This series, applying on top of block branch, enables drivers to use > coroutines for flush and discard. I kept aio_discard after discussing > with Kevin since it should be useful not only for raw-posix-aio, but also > for the userspace iSCSI backend (and in general for backends relying on > an external library that is designed around aio). > > BTW, with this patch we get "for free" the invariant that bdrv_aio_* > never returns a NULL acb (Stefan's patches already got to that point > for read/write, of course). > > v1->v2: > add bdrv_co_flush and bdrv_co_discard entry points > > Paolo Bonzini (2): > block: unify flush implementations > block: add bdrv_co_discard and bdrv_aio_discard support > > Stefan Hajnoczi (1): > block: drop redundant bdrv_flush implementation > > block.c | 258 +++++++++++++++++++++++++++++++++-------------------- > block.h | 5 + > block/blkdebug.c | 6 -- > block/blkverify.c | 9 -- > block/qcow.c | 6 -- > block/qcow2.c | 19 ---- > block/qed.c | 6 -- > block/raw-posix.c | 18 ---- > block/raw.c | 23 ++--- > block_int.h | 10 ++- > trace-events | 1 + > 11 files changed, 184 insertions(+), 177 deletions(-) > Thanks, applied all to the block branch. Kevin