From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [RFC][PATCH 08/45] Introduce MSIMessage structure Date: Mon, 17 Oct 2011 13:51:00 +0200 Message-ID: <4E9C16A4.9030402@siemens.com> References: <963bfdb7ee30cd65bec92c89cc04af0363de86c8.1318843693.git.jan.kiszka@siemens.com> <20111017114612.GE4537@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Alex Williamson , Marcelo Tosatti , Avi Kivity , "kvm@vger.kernel.org" , "qemu-devel@nongnu.org" To: "Michael S. Tsirkin" Return-path: In-Reply-To: <20111017114612.GE4537@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 2011-10-17 13:46, Michael S. Tsirkin wrote: > On Mon, Oct 17, 2011 at 11:27:42AM +0200, Jan Kiszka wrote: >> Will be used for generating and distributing MSI messages, both in >> emulation mode and under KVM. >> >> Signed-off-by: Jan Kiszka > > I would add > > uint64_t msix_get_address(dev, vector) > uint64_t msix_get_data(dev, vector) > > and same for msi. > > this would minimise the changes while still making it > possible to avoid code duplication in kvm. I'm introducing msi[x]_message_from_vector for that purpose later on. Or what do you mean? Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50489) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RFlih-0007tz-BL for qemu-devel@nongnu.org; Mon, 17 Oct 2011 07:51:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RFlig-00009H-CE for qemu-devel@nongnu.org; Mon, 17 Oct 2011 07:51:03 -0400 Received: from goliath.siemens.de ([192.35.17.28]:15050) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RFlig-000093-1M for qemu-devel@nongnu.org; Mon, 17 Oct 2011 07:51:02 -0400 Message-ID: <4E9C16A4.9030402@siemens.com> Date: Mon, 17 Oct 2011 13:51:00 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <963bfdb7ee30cd65bec92c89cc04af0363de86c8.1318843693.git.jan.kiszka@siemens.com> <20111017114612.GE4537@redhat.com> In-Reply-To: <20111017114612.GE4537@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC][PATCH 08/45] Introduce MSIMessage structure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Alex Williamson , Marcelo Tosatti , Avi Kivity , "kvm@vger.kernel.org" , "qemu-devel@nongnu.org" On 2011-10-17 13:46, Michael S. Tsirkin wrote: > On Mon, Oct 17, 2011 at 11:27:42AM +0200, Jan Kiszka wrote: >> Will be used for generating and distributing MSI messages, both in >> emulation mode and under KVM. >> >> Signed-off-by: Jan Kiszka > > I would add > > uint64_t msix_get_address(dev, vector) > uint64_t msix_get_data(dev, vector) > > and same for msi. > > this would minimise the changes while still making it > possible to avoid code duplication in kvm. I'm introducing msi[x]_message_from_vector for that purpose later on. Or what do you mean? Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux