From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [RFC][PATCH 08/45] Introduce MSIMessage structure Date: Mon, 17 Oct 2011 14:09:46 +0200 Message-ID: <4E9C1B0A.5080707@siemens.com> References: <963bfdb7ee30cd65bec92c89cc04af0363de86c8.1318843693.git.jan.kiszka@siemens.com> <20111017114612.GE4537@redhat.com> <4E9C16A4.9030402@siemens.com> <20111017120404.GG4537@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Marcelo Tosatti , "kvm@vger.kernel.org" , Alex Williamson , "qemu-devel@nongnu.org" To: "Michael S. Tsirkin" Return-path: Received: from david.siemens.de ([192.35.17.14]:22738 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751441Ab1JQMJv (ORCPT ); Mon, 17 Oct 2011 08:09:51 -0400 In-Reply-To: <20111017120404.GG4537@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 2011-10-17 14:04, Michael S. Tsirkin wrote: > On Mon, Oct 17, 2011 at 01:51:00PM +0200, Jan Kiszka wrote: >> On 2011-10-17 13:46, Michael S. Tsirkin wrote: >>> On Mon, Oct 17, 2011 at 11:27:42AM +0200, Jan Kiszka wrote: >>>> Will be used for generating and distributing MSI messages, both in >>>> emulation mode and under KVM. >>>> >>>> Signed-off-by: Jan Kiszka >>> >>> I would add >>> >>> uint64_t msix_get_address(dev, vector) >>> uint64_t msix_get_data(dev, vector) >>> >>> and same for msi. >>> >>> this would minimise the changes while still making it >>> possible to avoid code duplication in kvm. >> >> I'm introducing msi[x]_message_from_vector for that purpose later on. Or >> what do you mean? >> >> Jan > > It does not look like everyone actually wants the structure, > users seem to put it on stack and then immediately > unwrap it to get at the address/data. > So two accessorts get_data + get_address instead of one, will > remove the need to rework all code to use the structure. The idea of this patch is to start handling MSI messages as a single blob. There should be no need to ask a device for parts of that blobs this way. If you see use cases in this series, though, let me know. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58245) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RFm0w-0002pK-Dq for qemu-devel@nongnu.org; Mon, 17 Oct 2011 08:09:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RFm0q-000424-Qq for qemu-devel@nongnu.org; Mon, 17 Oct 2011 08:09:54 -0400 Received: from david.siemens.de ([192.35.17.14]:20862) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RFm0q-000420-By for qemu-devel@nongnu.org; Mon, 17 Oct 2011 08:09:48 -0400 Message-ID: <4E9C1B0A.5080707@siemens.com> Date: Mon, 17 Oct 2011 14:09:46 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <963bfdb7ee30cd65bec92c89cc04af0363de86c8.1318843693.git.jan.kiszka@siemens.com> <20111017114612.GE4537@redhat.com> <4E9C16A4.9030402@siemens.com> <20111017120404.GG4537@redhat.com> In-Reply-To: <20111017120404.GG4537@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC][PATCH 08/45] Introduce MSIMessage structure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Alex Williamson , Marcelo Tosatti , Avi Kivity , "kvm@vger.kernel.org" , "qemu-devel@nongnu.org" On 2011-10-17 14:04, Michael S. Tsirkin wrote: > On Mon, Oct 17, 2011 at 01:51:00PM +0200, Jan Kiszka wrote: >> On 2011-10-17 13:46, Michael S. Tsirkin wrote: >>> On Mon, Oct 17, 2011 at 11:27:42AM +0200, Jan Kiszka wrote: >>>> Will be used for generating and distributing MSI messages, both in >>>> emulation mode and under KVM. >>>> >>>> Signed-off-by: Jan Kiszka >>> >>> I would add >>> >>> uint64_t msix_get_address(dev, vector) >>> uint64_t msix_get_data(dev, vector) >>> >>> and same for msi. >>> >>> this would minimise the changes while still making it >>> possible to avoid code duplication in kvm. >> >> I'm introducing msi[x]_message_from_vector for that purpose later on. Or >> what do you mean? >> >> Jan > > It does not look like everyone actually wants the structure, > users seem to put it on stack and then immediately > unwrap it to get at the address/data. > So two accessorts get_data + get_address instead of one, will > remove the need to rework all code to use the structure. The idea of this patch is to start handling MSI messages as a single blob. There should be no need to ask a device for parts of that blobs this way. If you see use cases in this series, though, let me know. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux