From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54317)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1RFnnt-0005cC-Pl
	for qemu-devel@nongnu.org; Mon, 17 Oct 2011 10:04:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1RFnnn-0003TE-Ts
	for qemu-devel@nongnu.org; Mon, 17 Oct 2011 10:04:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:4103)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1RFnnn-0003T1-Ml
	for qemu-devel@nongnu.org; Mon, 17 Oct 2011 10:04:27 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9HE4QbN004048
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 17 Oct 2011 10:04:26 -0400
Message-ID: <4E9C35E8.9010907@redhat.com>
Date: Mon, 17 Oct 2011 16:04:24 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1318503845-11473-1-git-send-email-pbonzini@redhat.com>
	<1318503845-11473-5-git-send-email-pbonzini@redhat.com>
	<4E9C3616.3070000@redhat.com>
In-Reply-To: <4E9C3616.3070000@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 04/35] atapi: fill in AUDIO_CTL page
	correctly
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org

On 10/17/2011 04:05 PM, Kevin Wolf wrote:
>> >  diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c
>> >  index 347c38d..10f161f 100644
>> >  --- a/hw/ide/atapi.c
>> >  +++ b/hw/ide/atapi.c
>> >  @@ -731,6 +731,8 @@ static void cmd_mode_sense(IDEState *s, uint8_t *buf)
>> >                buf[7] = 0;
>> >
>> >                /* Fill with CDROM audio volume */
>> >  +            buf[8] = 0x0e;
>
> 0x0e would be more readable if it was written as MODE_PAGE_AUDIO_CTL.
>
>> >  +            buf[9] = 0x0e;
>
> And this is really the length. But I'm not sure if writing it as 24 - 10
> would help a lot.

Yes, the coincidence is ugly.

> Of course the same is true for the other pages, so it could be done for
> all of them on top. Or maybe you actually have included it later in the
> series?

Only for SCSI.  I can queue it as a cleanup for ATAPI.

Paolo